Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Split out actions, use code coverage test #114

Merged
merged 3 commits into from
Apr 27, 2023
Merged

chore: Split out actions, use code coverage test #114

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8dd5d91
chore: Split out actions, use code coverage test
iph Apr 27, 2023
f0602dc
upload code coverage
RomainMuller Apr 27, 2023
5fe6eb7
Merge remote-tracking branch 'origin/main' into actions
RomainMuller Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions .github/workflows/fmt-actions.yml → .github/workflows/pr-actions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ on:
name: Checks

jobs:
correctness:
name: correctness
lint_and_format:
name: Lint and Format
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -17,11 +17,10 @@ jobs:
override: true
components: rustfmt, clippy
# Ensure build.rs has ran before we assert formatting...
- name: Run tests
- name: Build
uses: actions-rs/cargo@v1
with:
command: test
args: --verbose
command: build
- name: Check formatting
uses: actions-rs/cargo@v1
with:
Expand All @@ -32,3 +31,15 @@ jobs:
with:
command: clippy
args: --manifest-path ./Cargo.toml -- -Adead-code -D warnings
testing:
name: Run Tests
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: stable
override: true
Comment on lines +40 to +43
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to have the llvm-tools-preview component in there, too (the coverage.sh will auto-install if missing, but it's cleaner to install upfront I think).

- name: Tests with Coverage
run: bash tasks/coverage.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd want to still upload the coverage to codecov...