Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RequestContextSettings.IgnoreCertificateErrors #3667

Closed
amaitland opened this issue Jul 2, 2021 · 1 comment
Closed

Remove RequestContextSettings.IgnoreCertificateErrors #3667

amaitland opened this issue Jul 2, 2021 · 1 comment
Assignees
Milestone

Comments

@amaitland
Copy link
Member

These properties are being removed upstream https://bitbucket.org/chromiumembedded/cef/issues/2899/remove

They haven't worked correctly for some time. The --ignore-certificate-errors will still allow ignoring errors.

The preferred approach is still to implement OnCertificateError to selectively allow a certificate and/or display a dialog to your users. See https://stackoverflow.com/a/35564187/852806 for an example.

@amaitland amaitland self-assigned this Jul 2, 2021
@amaitland amaitland added this to the 95.7.x milestone Sep 28, 2021
@amaitland amaitland changed the title Remove CefSettings.IgnoreCertificateErrors and RequestContextSettings.IgnoreCertificateErrors Remove RequestContextSettings.IgnoreCertificateErrors Oct 22, 2021
@amaitland
Copy link
Member Author

The RequestContextSettings.IgnoreCertificateErrors property was removed, the CefSettings.IgnoreCertificateErrors property
will set the command line arg

amaitland added a commit that referenced this issue Oct 22, 2021
….4638.54

Remove CefBrowserSettings.universal_access_from_file_urls and CefBrowserSettings.file_access_from_file_urls.
https://bitbucket.org/chromiumembedded/cef/commits/ff33d7f72144

Remove CefBrowserSettings.application_cache
https://bitbucket.org/chromiumembedded/cef/commits/370a7749e950ef6784c29a666d07a0b67148dd5f

Remove ignore_certificate_errors setting
https://bitbucket.org/chromiumembedded/cef/commits/aabe4ce466766f8bd9907e7fa30546a3afada214

RequestContextSettings.IgnoreCertificateErrors was removed, the CefSettings.IgnoreCertificateErrors property
now set the command line arg

Use CefRect for CefWindowInfo bounds
https://bitbucket.org/chromiumembedded/cef/commits/8587cc4e4bbc187aa989152e521318818b3f41d3

Additional overload has been added to pass in a Rect directly to SetAsChild

Rename SendFocusEvent to SetFocus
https://bitbucket.org/chromiumembedded/cef/commits/49a4611e28d7bbc221cff816d7c4a96c55ba2721

SendFocusEvent will now call SetFocus internally, the project internally has been updated to use SetFocus for WPF

Replace CefRequestCallback with CefCallback
https://bitbucket.org/chromiumembedded/cef/commits/3e7f1bb529442a6c7674262d9219df57964e9524

No changes to the API for this, I've kept the same interface and just mapped internally

Resolves #3857, #3667, #3668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant