Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BrowserSettings.UniversalAccessFromFileUrls and BrowserSettings.FileAccessFromFileUrls #3668

Closed
amaitland opened this issue Jul 2, 2021 · 1 comment
Closed

Remove BrowserSettings.UniversalAccessFromFileUrls and BrowserSettings.FileAccessFromFileUrls #3668

amaitland opened this issue Jul 2, 2021 · 1 comment
Assignees
@amaitland
Labels
breaking-change
Milestone
95.7.x

Comments

@amaitland
Copy link
Member

amaitland commented Jul 2, 2021 •
edited
Loading

Properties are being removed upstream https://bitbucket.org/chromiumembedded/cef/issues/2820/remove-cefbrowsersettings

Due to NetworkService
requirements these values must now be configured globally via command-line
flags ("allow-universal-access-from-files" and "allow-file-access-from-files"
respectively).

As per https://bitbucket.org/chromiumembedded/cef/commits/ff33d7f72144 they can still be set globally
@amaitland amaitland self-assigned this Jul 2, 2021
@amaitland
Copy link
Member Author

Using the command line flag (--allow-universal-access-from-files) instead of the in-code setting fixes the issue.

As per https://bitbucket.org/chromiumembedded/cef/issues/2820/remove-cefbrowsersettings#comment-55144848

@amaitland amaitland added this to the 95.7.x milestone Sep 28, 2021
@amaitland amaitland changed the title Remove BrowserSettings.UniversalAccessFromFileUrls Remove BrowserSettings.UniversalAccessFromFileUrls and BrowserSettings.FileAccessFromFileUrls Oct 22, 2021
amaitland added a commit that referenced this issue Oct 22, 2021
@amaitland
Upgrade to CEF 95.7.10+g00d4ad5+chromium-95.0.4638.54 / Chromium 95.0…
0e242a8 
….4638.54

Remove CefBrowserSettings.universal_access_from_file_urls and CefBrowserSettings.file_access_from_file_urls.
https://bitbucket.org/chromiumembedded/cef/commits/ff33d7f72144

Remove CefBrowserSettings.application_cache
https://bitbucket.org/chromiumembedded/cef/commits/370a7749e950ef6784c29a666d07a0b67148dd5f

Remove ignore_certificate_errors setting
https://bitbucket.org/chromiumembedded/cef/commits/aabe4ce466766f8bd9907e7fa30546a3afada214

RequestContextSettings.IgnoreCertificateErrors was removed, the CefSettings.IgnoreCertificateErrors property
now set the command line arg

Use CefRect for CefWindowInfo bounds
https://bitbucket.org/chromiumembedded/cef/commits/8587cc4e4bbc187aa989152e521318818b3f41d3

Additional overload has been added to pass in a Rect directly to SetAsChild

Rename SendFocusEvent to SetFocus
https://bitbucket.org/chromiumembedded/cef/commits/49a4611e28d7bbc221cff816d7c4a96c55ba2721

SendFocusEvent will now call SetFocus internally, the project internally has been updated to use SetFocus for WPF

Replace CefRequestCallback with CefCallback
https://bitbucket.org/chromiumembedded/cef/commits/3e7f1bb529442a6c7674262d9219df57964e9524

No changes to the API for this, I've kept the same interface and just mapped internally

Resolves #3857, #3667, #3668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amaitland amaitland

Labels
breaking-change
Projects
None yet
Milestone
95.7.x
Development

No branches or pull requests
1 participant
@amaitland