Add OnGotFocus and OnSetFocus

[amaitland]

Add OnGotFocus and OnSetFocus
Add CefFocusSource enum for mapping from cef_focus_source_t enum

[amaitland]

Currently the OnGotFocus, OnTakeFocus methods don't get called.

Anyone have any thoughts?

Once I can get those working I'll add the relevant event handlers so they can be handled client side.

[jornh]

I suspect it could have to do with this comment: https://github.com/cefsharp/CefSharp/blob/v31.0.0-pre1/CefSharp.Wpf/WebView.cs#L713

To me it sounds that we are actually in luck that OnTakeFocus() doesn't get called or end users would experience a NotImplementedException. I don't think we should require from those implementing CefSharp in their application that they must implement those handlers. If they don't implement anything it should still work.

I haven't actually tried it out but if you compare it to the CefSharp1 branch it looks like it was working there.

[perlun]

Let me ask a stupid question: why do we need this? Isn't the focus support (i.e. http://msdn.microsoft.com/en-US/library/system.windows.uielement.lostfocus(v=vs.110).aspx and friends) that WPF and Windows Forms already offers enough? What additional functionality do we gain by exposing the CEF API in this case?

[perlun]

Also, I would personally think it would be better if you finish the #327 stuff so we can merge it... 😜

[amaitland]

I was hoping that as with other browsers we'd be able to Set the focus to the address bar (something that I think would be a fairly common requirement) when OnTakeFocus is fired. I realise adding the the extra methods aren't required for that, it just made sense to me to look at finishing implementing all the methods exposed by CefFocusHandler whilst I was at it.

[amaitland]

As for #327 I was hoping to resolve #331 before progressing with a new PR that splits #327 up.
(I'm not trying to force #331 through either, I'd just like a clear direction one way or the other)

After that I'm happy to progress with tiding #327 up 😄

[brock8503]

@perlun I think that is a great question worth exploring. I am not 100% sure myself. How do we currently handle the case when the DOM HTMLElement.focus() is called. Shouldn't we also plum this focus event up to the WPF/WinForm control to make sure windows is aware of the focus change?

[amaitland]

Latest commit gets Focus working correctly in the WinForms Example

[amaitland]

@perlun As the Focus methods are relevant to the WinForms implementation (which I've been working on a Tabbed version), I'd like to properly implement these methods. As they don't currently work and may well not be relevant to the WPF version, I've moved them from the IWebBrowserInternal to IWinFormsWebBrowser and added a check so they're only called in the WinForms context.

Does this mitigate any of your previous objections?

[jankurianski]

@amaitland This PR would be a great feature - as we are trying to show the WinForms control dynamically as the user types in a separate TextBox, but ChromiumWebBrowser is stealing focus as it is being shown. Would be great to have access to OnSetFocus and be able to return true. Let me know if there's anything I can do to help test out this PR.

[amaitland]

@jankurianski Maybe have a look over the code and let me know if you've got any comments?

[amaitland]

Would be great to have access to OnSetFocus and be able to return true

Also those methods aren't exposed as yet, so need to create an interface I guess.

[jankurianski]

@amaitland If you're not in the middle of this change (as it seems it was a while ago), I'm happy to extend this further and expose a FocusHandler on ChromiumWebBrowser. Don't want to step on your toes though.

[jankurianski]

Extra space here after browser parameter.

[jankurianski]

Best as <summary> tags for the XML docs.

[amaitland]

If you're not in the middle of this change (as it seems it was a while ago), I'm happy to extend this further and expose a FocusHandler on ChromiumWebBrowser

Help finishing this one off is most welcome! 😄

[jankurianski]

https://github.com/numbersint/CefSharp/compare/feature/focus-handler-ext

• I added an IFocusHandler interface similar to IMenuHandler (similarly, it does not really apply for WPF, but I guess it is better to be consistent and leave it to the implementer to decide).
• Modified the WinForms example so that tabbing out of the browser moves focus to the address bar.
• I tested (but didn't commit) returning true from OnSetFocus - it works and prevents the browser from taking focus away from other controls (e.g. the address bar), so this will be good for my app.

@amaitland I couldn't figure out how to make a clean PR for your fork, as git seems to want to include every master commit since your branch. What do you reckon is easiest - for you to copy my commits over to update your PR, or for me to make a new PR to mainline CefSharp from my branch?

[amaitland]

@jankurianski I've just rebased this PR on the latest master

I'm happy if you want to cherry pick my changes and create a new PR. Whatever is easiest.

[amaitland]

Any thoughts on how we can preserve the current default behavior of the WinForms control?

void IWebBrowserInternal.OnTakeFocus(bool next)
{
    SelectNextControl(this, next, true, true, true);
}

[amaitland]

Closing in favor of #639