Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IFocusHandler #639

Merged
merged 9 commits into from
Nov 26, 2014
Merged

Add IFocusHandler #639

merged 9 commits into from
Nov 26, 2014

Conversation

jankurianski
Copy link
Member

Based on #341

@amaitland amaitland added this to the 37.0.0 milestone Nov 25, 2014
@amaitland amaitland mentioned this pull request Nov 25, 2014
Closed
@jankurianski
Copy link
Member Author

I've also added a DefaultFocusHandler which retains the current behaviour using SelectNextControl by default.

@jankurianski jankurianski mentioned this pull request Nov 25, 2014
Closed
@amaitland
Copy link
Member

@jankurianski Fantastic thanks! I'll look at this tomorrow, gotta get some 💤

@amaitland
Copy link
Member

@jankurianski Couple of minor things

  • Prefer not to use nested classes (not really a big deal)
  • Minor formatting changes

I'm happy to resolve those after merging. As always, fantastic work 👍 Thanks 😄

@amaitland amaitland merged commit 9c8fab9 into cefsharp:master Nov 26, 2014
@amaitland amaitland mentioned this pull request Nov 26, 2014
Merged
@jankurianski
Copy link
Member Author

@amaitland Roger that. I saw the changes you made on master and will keep the issues in mind for future PRs. Thanks for the quick merge! 👍

@amaitland
Copy link
Member

@jankurianski No probs 👍

@numbersint numbersint deleted the feature/focus-handler-ext branch December 22, 2014 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
37.0.0-pre01
Development

Successfully merging this pull request may close these issues.
2 participants
@jankurianski @amaitland