Added parameter for lowercasing JS functions (or not)

[exinferis]

Used to give the dev the possibility to decide wether JS methods/objects/parameters should be automatically made first letter lowercase or not.

[exinferis]

This is the suggested fix for #922

[amaitland]

Spaces not tabs see https://github.com/cefsharp/CefSharp/blob/master/CONTRIBUTING.md#coding-style

[amaitland]

Comments inline, needs a bit of refactoring and cleanup. Nothing major though.

[amaitland]

Thinking about this a little more, might be worth just using an optional param instead of overloading, keeps the lines of code down as they're mostly just wrapper methods until they get passed for analysis.

Also I think IWebBrowser probably needs to be updated to include the new signature for whatever we go with.

[exinferis]

Shall I change my pull request to fulfill the coding guidelines etc, or would you suggest to implement the alternative solution using optional parameters?

[amaitland]

I think optional params makes sense. What do you think?

[exinferis]

I do not know the internals of the project well enough to really be sure, but I also think that an optional parameter makes sense.
Why and where needs the IWebBrowserto be updated in that case?

[amaitland]

It's only the external methods that require optional params, specifically those on the ChromiumWebBrowser instances, all other methods just need the value passed.

The IWebBrowser.RegisterJsObject method will need to be updated including xml docs.
https://github.com/cefsharp/CefSharp/blob/master/CefSharp/IWebBrowser.cs#L89

[perlun]

Coming in a bit late here, but just a suggestion: lowercaseMethodNames isn't really a proper name, since it's not about "lower-casing" per se, but rather "javascript-casing". So "javascriptCaseMethodNames" or something to the like would make more sense, IMHO. What do you think @amaitland?

[perlun]

(just so we keep the public API clean)

[amaitland]

So "javascriptCaseMethodNames" or something to the like would make more sense,

Hadn't really though about it 😄 As it applies to both properties as well, it should probably have a more generic name. I'm all for improving variable naming as a general thing 👍

@perlun Do you have time to submit a PR?

[amaitland]

(Or even just apply the changes directly to master)

[exinferis]

That means that you go under the assumption, that all js functions are per se lowercase (so javascriptCaseMethodNames refers to lowercase) which isn't always the case - this is a widespread behaviour, but not necessary nor wanted in many cases. I find javascriptCaseMethodNames misleading - it is about lowercasing, since "javascript-casing" does not really exist as such.

[amaitland]

Technically it's probably camel-case that we're referring to, to me that's a fairly universal term. So something like camelCaseJavascriptNames is probably quite universal. Thoughts?

[exinferis]

Sounds good.