Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename lowerCaseJavascriptNames to camelCaseJavascriptNames #951

Merged
merged 1 commit into from
Apr 20, 2015

Conversation

amaitland
Copy link
Member

As per discussion starting #923 (comment)

@amaitland amaitland added this to the 39.0.1 milestone Apr 16, 2015
@amaitland
Copy link
Member Author

@perlun Happy with camelCaseJavascriptNames?

@perlun
Copy link
Member

perlun commented Apr 20, 2015

Yep, that's much better.

There are probably people that would argue that this should be false by default. I don't know; I like the current behavior (after all, I was the one that implemented it in the first place. 😎) but I understand it's a but unintuitive. So you guys could consider revisiting it for v41.0 or so.

@amaitland
Copy link
Member Author

So you guys could consider revisiting it for v41.0 or so.

That would be a breaking change, so I'm happy just to leave it. Fact that you can now choose is enough I think 👍

amaitland added a commit that referenced this pull request Apr 20, 2015
Rename lowerCaseJavascriptNames to camelCaseJavascriptNames
@amaitland amaitland merged commit 3cb2363 into cefsharp:master Apr 20, 2015
@amaitland amaitland deleted the enhancement/jsb-camelcase branch April 20, 2015 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants