Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autodetect mnemonic language #5204

Closed
gnardini opened this issue Sep 25, 2020 · 1 comment · Fixed by #5825 or #6372
Closed

Autodetect mnemonic language #5204

gnardini opened this issue Sep 25, 2020 · 1 comment · Fixed by #5825 or #6372
Labels
Priority: P2 Major wallet

Comments

@gnardini
Copy link
Contributor

gnardini commented Sep 25, 2020 •
edited by tarikbellamine
Loading

Expected Behavior

When importing a mnemonic, it works if it's valid regardless of the language the mnemonic and app are in.

Current Behavior

If the app is in Spanish and we try to import an English mnemonic, we get an error.
@gnardini
Copy link
Contributor Author

Fixed in #5198

@gnardini gnardini mentioned this issue Nov 11, 2020
Merged
mergify bot pushed a commit that referenced this issue Nov 18, 2020
@gnardini
[Wallet] Restore mnemonics in any language if default fails (#5825)
70334b3 
### Description

Use the words in the mnemonic to tell which language the mnemonic is actually in and use that to restore the account instead of using the app's language.

### Tested

Manually and there's a unit test as well

### Related issues

- Fixes #5204

### Backwards compatibility

N/A
@tarikbellamine tarikbellamine mentioned this issue Jan 5, 2021
Merged
mergify bot pushed a commit that referenced this issue Jan 7, 2021
@tarikbellamine
Mnemonic validation flexibility within Valora (#6372)
4276a18 
### Description
This PR aims to do two things:
- Allow the mnemonic to be entered in any language recognized by Valora (i.e., Valora does not need to be set to the language the mnemonic is)
- Validate the mnemonic regardless of accented letters

### Other changes
No

### Tested
Yes

### Related issues

- Fixes #6369
- Fixes #6371
- Fixes #5204

### Backwards compatibility
Yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: P2 Major wallet
Projects
None yet
Milestone
No milestone
2 participants
@gnardini @tarikbellamine