-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wallet] Validate mnemonic in the app's language #5198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 Thanks for fixing this critical issue!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! Would love to get this in 1.2.0 if the issue was actually that any non-English mnemonics were resulting in errors.
Can we please add some copy to explain to the user that their app language must match their mnemonic language? That should help mitigate that confusion for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on both iOS and Android just in case and everything looks good. Great work :)
### Description Validating the mnemonic was defaulting to english, so it was not possible to restore accounts created in Spanish or other languages. It is possible now to restore in Spanish, but only if the app's language is set to Spanish. I wonder if we could do something smarter and figure out the language of the mnemonic based on the first word/s so we don't depend on the language chosen by the user. ### Tested On the simulator ### Related issues - Fixes celo-org#5192 ### Backwards compatibility Yes
@tarikbellamine I have verified this issue on latest test flight build (25) & Android internal build Android internal build 1.2.0(1004294313) and observe issue is still repro |
@Lss-Ankit Thanks for testing this! What you see is expected, this change makes it so you can only use an account key of the same language you chose for the app. So, if the app is in Spanish you need a spanish Account Key. To create one, you need to create an account with the language as spanish and the created account key will be in spanish. |
Hi @gnardini thank you so much for giving more information about this task
Can you please let me know if i need to test anything else Thanks! |
Sounds like you've covered everything @Lss-Ankit. I think there is no further action needed on this PR :) |
Thanks @tarikbellamine for the confirmation. |
Description
Validating the mnemonic was defaulting to english, so it was not possible to restore accounts created in Spanish or other languages.
It is possible now to restore in Spanish, but only if the app's language is set to Spanish. I wonder if we could do something smarter and figure out the language of the mnemonic based on the first word/s so we don't depend on the language chosen by the user.
Tested
On the simulator
Related issues
Backwards compatibility
Yes