Fix fee position adding when updating fees (#2089)

* Add fallback * Add fee position when updating fees
centrifuge · Apr 18, 2024 · 934f16c · 934f16c
1 parent b4f0fb2
commit 934f16c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/centrifuge-app/src/components/PoolFees/index.tsx b/centrifuge-app/src/components/PoolFees/index.tsx
@@ -167,7 +167,7 @@ export function PoolFees() {
             percentOfNav: feeChainData?.amounts?.percentOfNav,
             pendingFees: feeChainData?.amounts.pending,
             receivingAddress: feeChainData?.destination,
-            feePosition: feeMetadata?.feePosition,
+            feePosition: feeMetadata?.feePosition || 'Top of waterfall',
             action:
               (isAllowedToCharge || poolAdmin) && !fixedFee ? (
                 <RouterLinkButton

diff --git a/centrifuge-js/src/modules/pools.ts b/centrifuge-js/src/modules/pools.ts
@@ -3611,10 +3611,9 @@ export function getPoolsModule(inst: Centrifuge) {
               }) || []),
               ...add.map((metadata, index) => {
                 return {
-                  // chain refactor required: feeId needs to be assigned to fee when it's proposed
-                  // until then multiple fees have to be added at once or all pending fees have to be applied before adding more
                   id: parseInt(lastFeeId.toHuman() as string) + index + 1,
                   name: metadata.fee.name,
+                  feePosition: metadata.fee.feePosition,
                 }
               }),
             ],