Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fee position adding when updating fees #2089

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Fix fee position adding when updating fees #2089

merged 2 commits into from
Apr 18, 2024

Conversation

sophialittlejohn
Copy link
Collaborator

@sophialittlejohn sophialittlejohn commented Apr 17, 2024 •
edited by jpangelle
Loading

Description

This pull request...

#2086

Approvals

  • Dev
  • Dev
  • Designer
  • Product

Screenshots

Impact

@github-actions GitHub Actions
Copy link

PR deployed in Google Cloud
URL: https://app-pr2089.k-f.dev
Commit #: 568ade2
To access the functions directly check the corresponding deploy Action

@github-actions GitHub Actions
Copy link

PR deployed in Google Cloud
URL: https://pr2089-app-ff-production.k-f.dev
Commit #: 568ade2
To access the functions directly check the corresponding deploy Action

@sophialittlejohn sophialittlejohn merged commit 934f16c into main Apr 18, 2024
22 checks passed
@sophialittlejohn sophialittlejohn deleted the add-fee-position-fallback branch April 18, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpangelle jpangelle jpangelle approved these changes

@onnovisser onnovisser Awaiting requested review from onnovisser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophialittlejohn @jpangelle