Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: finance form validation, subql self hosted, withdraw batch fix #2436

Conversation

sophialittlejohn
Copy link
Collaborator

Description

This pull request...

  • fixes validation in finance forms that broke due to withdraw address
  • points subql to self hosted version
  • fixes pending nav calculation in nav management table
  • removes withdraw batch tx if there are no withdraw addresses needed (specifically tested for transferring funds from cash to external asset)

Approvals

  • Dev

Screenshots

Impact

@sophialittlejohn sophialittlejohn changed the title Hotfix actual fix financing and subql Hotfix: finance form validation, subql self hosted, withdraw batch fix Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

PR deployed in Google Cloud
URL: https://pr2436-app-ff-production.k-f.dev
Commit #: 9b6332f
To access the functions directly check the corresponding deploy Action

Copy link

github-actions bot commented Sep 6, 2024

PR deployed in Google Cloud
URL: https://app-pr2436.k-f.dev
Commit #: 9b6332f
To access the functions directly check the corresponding deploy Action

@sophialittlejohn sophialittlejohn merged commit 699bebd into hotfix-financing-and-subql Sep 6, 2024
11 checks passed
@sophialittlejohn sophialittlejohn deleted the hotfix-actual-fix-financing-and-subql branch September 6, 2024 16:11
sophialittlejohn added a commit that referenced this pull request Sep 6, 2024
#2436) (#2437)

* Point subquery to new version

* Fix pending NAV calc

* Fix mistake in subquery urls

* Fix withdraw address validation

* Include withdraw batch only where necessary

* Undo accidental commit

* Revalidate forms when source changes
sophialittlejohn added a commit that referenced this pull request Sep 9, 2024
* Hotfix: finance form validation, subql self hosted, withdraw batch fix (#2436)

* Point subquery to new version

* Fix pending NAV calc

* Fix mistake in subquery urls

* Fix withdraw address validation

* Include withdraw batch only where necessary

* Undo accidental commit

* Revalidate forms when source changes

* Add cursor based pagination for asset transactions (#2438)
sophialittlejohn added a commit that referenced this pull request Sep 11, 2024
* Hotfix: finance form validation, subql self hosted, withdraw batch fix (#2436)

* Point subquery to new version

* Fix pending NAV calc

* Fix mistake in subquery urls

* Fix withdraw address validation

* Include withdraw batch only where necessary

* Undo accidental commit

* Revalidate forms when source changes

* Add cursor based pagination for asset transactions (#2438)

* Hotfix: Nav Management dynamic Card (#2441)

* Make change asset in asset valuation dynamic

* Fix nav management card value in Drawer (#2442)

* wip: try fixing values

* wip: try fixing build

* wip: try fixing number conversion

* fix errors

* wip: make numbers correct

* Align nav managment tables on page and drawer

---------

Co-authored-by: Onno Visser <23527729+onnovisser@users.noreply.github.com>
Co-authored-by: sophian <littlejohn.sophia@gmail.com>

---------

Co-authored-by: Frederik Gartenmeister <mustermeiszer@posteo.de>
Co-authored-by: Onno Visser <23527729+onnovisser@users.noreply.github.com>

---------

Co-authored-by: Frederik Gartenmeister <mustermeiszer@posteo.de>
Co-authored-by: Onno Visser <23527729+onnovisser@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants