Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: merge back into main (nav management) #2444

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

sophialittlejohn
Copy link
Collaborator

Description

This pull request...

#

Approvals

  • Dev

Screenshots

Impact

sophialittlejohn and others added 4 commits September 6, 2024 12:11
#2436)

* Point subquery to new version

* Fix pending NAV calc

* Fix mistake in subquery urls

* Fix withdraw address validation

* Include withdraw batch only where necessary

* Undo accidental commit

* Revalidate forms when source changes
* Make change asset in asset valuation dynamic

* Fix nav management card value in Drawer (#2442)

* wip: try fixing values

* wip: try fixing build

* wip: try fixing number conversion

* fix errors

* wip: make numbers correct

* Align nav managment tables on page and drawer

---------

Co-authored-by: Onno Visser <23527729+onnovisser@users.noreply.github.com>
Co-authored-by: sophian <littlejohn.sophia@gmail.com>

---------

Co-authored-by: Frederik Gartenmeister <mustermeiszer@posteo.de>
Co-authored-by: Onno Visser <23527729+onnovisser@users.noreply.github.com>
Copy link

PR deployed in Google Cloud
URL: https://pr2444-app-ff-production.k-f.dev
Commit #: 97d7fc3
To access the functions directly check the corresponding deploy Action

Copy link

PR deployed in Google Cloud
URL: https://app-pr2444.k-f.dev
Commit #: 97d7fc3
To access the functions directly check the corresponding deploy Action

Copy link
Contributor

@kattylucy kattylucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sophialittlejohn sophialittlejohn merged commit 10212d1 into main Sep 11, 2024
13 checks passed
@sophialittlejohn sophialittlejohn deleted the hotfix-nav-management branch September 11, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants