Polkadot v0.9.29 #977
Polkadot v0.9.29 #977
Conversation
gruberb
added
Q0-trivial
| @@ -185,4 +185,22 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> { | |||
| .saturating_add(T::DbWeight::get().reads(2 as Weight)) | |||
| .saturating_add(T::DbWeight::get().writes(1 as Weight)) | |||
| } | |||
|
|
|||
| fn buy_item() -> Weight { | |||
There was a problem hiding this comment.
Need input here how to weigh things or what value is the right one! Currently it's 44_219_000 but need advice on how to weigh functions @branan @mustermeiszer
There was a problem hiding this comment.
So buy_item is a new extrinsic from unqiues?
These files here are automatically generated. For making this compilable just put a zero weight. E.g. Weight::from_ref_time(0). We can go through running the benchmarks in the cloud or locally tomorrow. This will then generate the correct values for buy_item
| @@ -1016,6 +1016,7 @@ parameter_types! { | |||
| pub const PotId: PalletId = cfg_types::ids::STAKE_POT_PALLET_ID; | |||
| pub const MaxCandidates: u32 = 1000; | |||
| pub const MinCandidates: u32 = 5; | |||
| pub const MaxVoters: u32 = 10 * 1000; | |||
There was a problem hiding this comment.
Taken from the latest polkadot runtime.
There was a problem hiding this comment.
I have to take a look at the collator selection logic and why a voter is needed now. Could you also take a look and maybe see, what voters will do?
|
@gruberb can we pull the latest v0.9.29 commits of substrate & cumulus? |
@mikiquantum Is there a specific commit you have in mind? I re-ran |
|
@gruberb The commit on both cumulus & substrate is now at the top 👍 . I can see that the lock file still pulls 0.9.28 versions too, do you know if we could only limit to the latest 0.9.29? |
Yeah, the latest |
|
@gruberb ah ok! Yeah there is always a delay, as soon as polkadot is upgraded to that version, hopefully that lib is updated as well. We can keep this open for a bit longer. |
|
@gruberb Seems that it has been merged shaunxw/xcm-simulator#38. Is there anything else needed to get this in? |
Just updated and re-ran everything. A fresh new >200 places where I have to update weights since the last rebase. So will work on that again today. After these are fixed, there is one thing missing which is some crates pull a different version of |
|
Superseded by #1041, so we can have multiple of us cooperating on the same branch. |
Description
Upgrading
centrifuge-chainto the latest Polkadot version,v0.9.29Fixes #976
Changes and Descriptions
This change also includes the upgrade to
v0.9.28: https://github.com/paritytech/polkadot/releases/tag/v0.9.28Type of change
Please delete options that are not relevant.
How Has This Been Tested?
cargo build --releasecargo test --workspace --release --features test-benchmarks,try-runtime,runtime-benchmarksChecklist:
parachainbranch