update travis to run functional test against different kube version #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
force-pushed
the
multi-kube
branch
9 times, most recently
from
4e90b88 to
a45ece3
Compare
|
@humblec @ShyamsundarR PTAL |
ShyamsundarR
requested changes
Jun 13, 2019
| - curl -sf | ||
| "https://install.goreleaser.com/github.com/golangci/golangci-lint.sh" | ||
| "https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh" |
There was a problem hiding this comment.
I always cringe when using master branch versions of dependencies... letting this one pass through, and hopefully in the future we would stick to a version.
There was a problem hiding this comment.
will go back to the older version of code once the above-mentioned issue is fixed
| | bash -s -- -b $GOPATH/bin "${GOLANGCI_VERSION}" | ||
| script: | ||
| - scripts/lint-text.sh --require-all | ||
| - scripts/lint-go.sh | ||
| - scripts/test-go.sh | ||
|
|
||
| - name: cephcsi | ||
| - name: cephcsi with kube 1.13.7 | ||
| script: | ||
| - scripts/skip-doc-change.sh || travis_terminate 0; |
There was a problem hiding this comment.
We can possibly move this line up to the static-check-make section (last line) and hence skip the check in future sections like in line 58 in the new file.
Can be taken care the next time we edit this file.
There was a problem hiding this comment.
yes nice idea will update if it works
updated travis to run functional tests against different kubernetes versions Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
ShyamsundarR
approved these changes
Jun 13, 2019
|
@humblec can you review this. This will Fix CI issue also |
humblec
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
updated Travis to run functional tests against different kubernetes versions
1.13.7 and 1.14.3
This will ensure csi will be working against 2 kube major version
if required we can add all major version to test against it
Signed-off-by: Madhu Rajanna madhupr007@gmail.com