Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update travis to run functional test against different kube version #429

Merged
merged 1 commit into from
Jun 14, 2019
+28 −13
Merged

update travis to run functional test against different kube version #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,11 @@ go: 1.11.x

env:
global:
- GOLANGCI_VERSION="v1.17.0"
- GOLANGCI_VERSION=v1.17.0
- TEST_COVERAGE=stdout
- GO_METALINTER_THREADS=1
- GO_COVER_DIR=_output
- VM_DRIVER=none
- KUBE_VERSION=v1.14.2
- MINIKUBE_VERSION=v1.1.1
- CHANGE_MINIKUBE_NONE_USER=true
- KUBECONFIG=$HOME/.kube/config
Expand All @@ -39,26 +38,26 @@ jobs:
- pip install --user --upgrade pip
- pip install --user yamllint
# install golangci-lint
# workaround for https://github.com/golangci/golangci-lint/issues/575
- curl -sf
"https://install.goreleaser.com/github.com/golangci/golangci-lint.sh"
"https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always cringe when using master branch versions of dependencies... letting this one pass through, and hopefully in the future we would stick to a version.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will go back to the older version of code once the above-mentioned issue is fixed

| bash -s -- -b $GOPATH/bin "${GOLANGCI_VERSION}"
script:
- scripts/lint-text.sh --require-all
- scripts/lint-go.sh
- scripts/test-go.sh

- name: cephcsi
- name: cephcsi with kube 1.13.7
script:
- scripts/skip-doc-change.sh || travis_terminate 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can possibly move this line up to the static-check-make section (last line) and hence skip the check in future sections like in line 58 in the new file.

Can be taken care the next time we edit this file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes nice idea will update if it works

- make image-cephcsi || travis_terminate 1;
- sudo scripts/minikube.sh up || travis_terminate 1;
# pull docker images to speed up e2e
- scripts/minikube.sh cephcsi
- scripts/minikube.sh k8s-sidecar
- "sudo chown -R travis: $HOME/.minikube /usr/local/bin/kubectl"
# functional tests
- make func-test TESTOPTIONS='--rook-version=v1.0.1 \
--deploy-rook=true --deploy-timeout=10 -timeout=30m -v'
- scripts/travis-functest.sh v1.13.7 || travis_terminate 1;

- name: cephcsi with kube 1.14.3
script:
- scripts/skip-doc-change.sh || travis_terminate 0;
- make image-cephcsi || travis_terminate 1;
- scripts/travis-functest.sh v1.14.3 || travis_terminate 1;

deploy:
- provider: script
Expand Down
2 changes: 1 addition & 1 deletion scripts/skip-doc-change.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ function check_file_present() {
local file=$1
for FILE in "${FILES[@]}"; do
if [[ $file =~ $FILE ]]; then
if [[ $file =~ minikube.sh ]]; then
if [[ $file =~ (minikube.sh|travis-functest.sh) ]]; then
continue
fi
return 0
Expand Down
16 changes: 16 additions & 0 deletions scripts/travis-functest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#!/bin/bash
ShyamsundarR marked this conversation as resolved.
Show resolved Hide resolved
set -e

# This script will be used by travis to run functional test
# against different kuberentes version
export KUBE_VERSION=$1
sudo scripts/minikube.sh up
# pull docker images to speed up e2e
sudo scripts/minikube.sh cephcsi
sudo scripts/minikube.sh k8s-sidecar
sudo chown -R travis: "$HOME"/.minikube /usr/local/bin/kubectl
# functional tests

go test github.com/ceph/ceph-csi/e2e --rook-version=v1.0.1 --deploy-rook=true --deploy-timeout=10 -timeout=30m -v

sudo scripts/minikube.sh clean