Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Carbon Site fails in IE11 after upgrade from marked@0.7.0 to 0.8.0 #32

Closed
mrw100 opened this issue Mar 2, 2020 · 2 comments
Closed
Assignees

Comments

@mrw100
Copy link
Contributor

mrw100 commented Mar 2, 2020

Describe the bug
A syntax error is thrown when you try to access carbon's dev site, which uses this helper. There is a known error in markedjs@0.8.0 that breaks support of IE.

Workaround specified in the markedjs github issue is to import marked from lib:
markedjs/marked#1585 (comment)

To Reproduce
Steps to reproduce the behavior:

  1. Launch the carbon dev site in IE
    https://engineering.cerner.com/carbon-graphs/#/

Expected behavior
The site should render in Internet Explorer

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Internet Explorer 11
@ShettyAkarsh
Copy link

PR #33 Fixed this. hence closing this now.

@pranav300
Copy link
Contributor

pranav300 commented Mar 27, 2020

Reopening the issue as this wasn't fixed by the PR #33.
If we change import to require, Something like this:
const marked = require('marked/lib/marked');
It seemed to work.

Cc / @mraplumb

pranav300 added a commit that referenced this issue Apr 1, 2020
@pranav300 pranav300 self-assigned this Apr 1, 2020
mraplumb pushed a commit that referenced this issue May 28, 2020
# [1.11.0](v1.10.2...v1.11.0) (2020-05-28)

### Fix

* trigger the release for carbon site helpers (#46) ([aff1193](aff1193)), closes [#46](#46)

### Update

* updated import (fixes #32) (#38) ([0c49a91](0c49a91)), closes [#32](#32) [#38](#38)

### Upgrade

* Bump acorn from 6.4.0 to 6.4.1 (#34) ([3f0b083](3f0b083)), closes [#34](#34)
* Greenkeeper/url loader 4.1.0 (#41) ([a995c9c](a995c9c)), closes [#41](#41)
* Update eslint-plugin-react-hooks to the latest [skip ci] (#37) ([2b5ba26](2b5ba26)), closes [#37](#37)
* Update eslint-plugin-react-hooks to the latest [skip ci] (#44) ([2d83b65](2d83b65)), closes [#44](#44)
* Update less-loader to the latest [skip ci] (#40) ([3db7df1](3db7df1)), closes [#40](#40)
* Update marked to the latest [skip ci] (#39) ([6754d7a](6754d7a)), closes [#39](#39)
* Update prettier to the latest [skip ci] (#36) ([45ec05b](45ec05b)), closes [#36](#36)
* Update react-ace to the latest [skip ci] (#47) ([16fb081](16fb081)), closes [#47](#47)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants