This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Fix: Import marked from marked/lib/marked (Fixes #32) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Best reviewed: commit by commit
Optimal code review plan
|
mraplumb
reviewed
Mar 10, 2020
| @@ -4882,8 +4882,7 @@ | |||
| "version": "1.0.0", | |||
| "resolved": "https://registry.npmjs.org/assert-plus/-/assert-plus-1.0.0.tgz", | |||
| "integrity": "sha1-8S4PPF13sLHN2RRpQuTpbB5N1SU=", | |||
| "dev": true, | |||
| "optional": true | |||
There was a problem hiding this comment.
@mrw100 were these changes to remove the optional property done by "npm install" or were they removed for another reason?
There was a problem hiding this comment.
These changes came from npm install
mraplumb
approved these changes
Mar 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (Check any that's applicable)
Does this introduce a breaking change?
What changes did you make? (Give an overview)
The upgrade from marked@0.7.0 to 0.8.0 causes issues in the carbon-graphs dev site in Internet Explorer(#32) . This is the workaround I found on the issue that was logged against markedjs.