Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: custom colors for timeline from vscode prefs - v1.5.1 #166

Closed
wants to merge 55 commits into from
Closed

fix: custom colors for timeline from vscode prefs - v1.5.1 #166

wants to merge 55 commits into from

Conversation

lukecotter
Copy link
Contributor

@lukecotter lukecotter commented Oct 4, 2022 •
edited
Loading

Fixes the setting of custom colors on the timeline from vscode settings.

Description

  • Fixes the custom color preferences from vscode not being used

Type of change

  • Bug fix
  • New feature
  • Breaking change

Changes

  • Fix color prefs fro vscode settings not being used
  • Update release
  • Update change log

Any images/ gifs (if appropriate)

image

fixes #163

sjonwilson and others added 30 commits July 18, 2022 15:14
@sjonwilson
Implement breadcrumbs in the call tree (on click)
46ad2c7
@sjonwilson
Update change log
d10c2a4
@sjonwilson
Exclude scroll-padding from call-tree clicks
e4c402e
@sjonwilson
Enhance breadcrumb text
7b6d6e4
@sjonwilson
Go to code on cmd-click
c656bdd
@sjonwilson
Merge remote-tracking branch 'origin/main' into poc/breadcrumbs
8bf84a3 
# Conflicts:
#	CHANGELOG.md
@sjonwilson
Merge remote-tracking branch 'origin/main' into poc/breadcrumbs
18d2f81 
# Conflicts:
#	CHANGELOG.md
@sjonwilson
Mend breadcrumb click
918b4dc
@sjonwilson
Fix the changelog after merging in main
c9ba22f
@lukecotter
ci(jest): add command to speed up tests in ci
6ab49bd 
Runs test in band (--runInBand) which is know to speed up tests.
@lukecotter
build(rollup): restrict files to compile
527908c 
Reduce the number of ts files that rollup
needs to deal with to speed up compile.
@lukecotter
build(ts): update target JS version to es2021
6146f0e 
Is supported by node 16 + all major browser versions.
https://kangax.github.io/compat-table/es2016plus/
@lukecotter
build(npm): remove babel
ed31779 
No longer in use after the rollup switch
@lukecotter
chore(npm deps): update npm deps to latest compatible versions
9ac7a4c 
- All deps updated to compatible versions e.g if ^1.0.0 latest of v1 is taken.
- pkgforce is being fixed at v2.1.4 due to a publishing issue in v2.3.3.
@lukecotter
chore(npm deps): update npm deps to latest major versions
b20a311
@lukecotter
Merge branch 'main' into feat-typescript-improve-speed
d139fa3
@sjonwilson
Merge remote-tracking branch 'origin/main' into poc/breadcrumbs
c95b516 
# Conflicts:
#	CHANGELOG.md
@lukecotter
refactor: remove circular dependency on Main.ts
d6033e9
@lukecotter
test: delete empty test class
266d510
@lukecotter
build(ts): additional typescript options enabled
df91aa5
@lukecotter
docs: update building md formatting
7e894a2
@lukecotter
build: update watch to use rollup
76938e4
@lukecotter
feat: enable prettier-eslint formatting
f2b07aa 
- Run Prettier as an ESLint rule
- Enables recommended ESLint rules for typescript
@lukecotter
style: format all lana ts files with prettier
cc8a4e2 
Appply prettier formatting on all ts files in the /lana/src folder.
@lukecotter
style: format all log-viewer ts files with prettier
3f5415b 
Apply prettier formatting on all ts files in the /log-viewer/modules folder.
@lukecotter
style: format all remaining files with prettier
c07c3b5
@lukecotter
style: auto fix eslint issues in lana
2d0d6f1
@lukecotter
refactor: apply eslint rule suggestions to lana
d5ae68f
@lukecotter
refactor: apply eslint rule suggestions to logviewer
a1fc45d
@lukecotter
refactor: default duration to 0
47b6ec3
lukecotter and others added 24 commits September 1, 2022 17:29
@lukecotter
refactor: remove unused events (eslint warnings)
fea118d
@lukecotter
refactor: move imports from main to lit components that need them
67bb7bc
@lukecotter
refactor: use interface for type when setting timeline colours
e83a503
@lukecotter
refactor: remove implict non null asertion on canvas context
665b53c 
eslint suggestions
@lukecotter
refactor: enable use of _ to mark function args as not used eslint
24233a4
@lukecotter
refactor: remove unused class
f11415b
@lukecotter
refactor: default self time to 0 insead of null
00c32c4
@sjonwilson
Code review changes
beefd6e
@sjonwilson @lcottercertinia
Update CHANGELOG.md
ac34bb4 
Co-authored-by: Luke Cotter <81575432+lcotterffdc@users.noreply.github.com>
@sjonwilson @lcottercertinia
Update CHANGELOG.md
bc508e0 
Co-authored-by: Luke Cotter <81575432+lcotterffdc@users.noreply.github.com>
@lcottercertinia
Merge pull request certinia#154 from lukecotter/feat-153-prettier-esl…
efba95d 
…int-rules

chore: setup prettier + eslint rules + format classes
@lukecotter
Merge branch 'main' into feat-153-fix-eslint-errors
1b7fcda
@lcottercertinia
Merge pull request certinia#155 from lukecotter/feat-153-fix-eslint-e…
b04201c 
…rrors

chore: fix eslint errors
@sjonwilson
Merge remote-tracking branch 'origin/main' into poc/breadcrumbs
26e5efd 
# Conflicts:
#	log-viewer/modules/TreeView.ts
#	log-viewer/modules/parsers/TreeParser.ts
#	log-viewer/resources/css/TreeView.css
@sjonwilson
Remove redundant @ts-ignore lines
21451c1
@lukecotter
Merge branch 'main' into feat-156-typescript-improve-speed
a04711a
@sjonwilson
Run prettier
9cea60d
@sjonwilson
Allow CTRL-click for windows users
b2b6720
@lcottercertinia
Merge pull request certinia#143 from financialforcedev/poc/breadcrumbs
b2f2b8b 
Implement breadcrumbs in the call tree (on click)
@lukecotter
Merge branch 'main' into feat-156-typescript-improve-speed
2fa1011
@lukecotter
build: enable isolated modules
9d930ff
@lcottercertinia
Merge pull request certinia#157 from lukecotter/feat-156-typescript-i…
f823a92 
…mprove-speed

feat: typescript compile improve speed
@lukecotter
fix: custom colors for timeline from vscode prefs
b7d2ec6 
Fixes the setting of custom colors on the timeline from vscode settings.
@lukecotter
chore: bump version to v1.5.1
7ee1c69
@lukecotter lukecotter mentioned this pull request Oct 4, 2022
Closed
3 tasks
@lcottercertinia lcottercertinia changed the title fix: custom colors for timeline from vscode prefs fix: custom colors for timeline from vscode prefs - v1.5.1 Oct 4, 2022
@lcottercertinia lcottercertinia marked this pull request as draft October 4, 2022 14:56
@lukecotter lukecotter closed this Oct 4, 2022
@lukecotter lukecotter deleted the bug-163-fix-custom-timeline-colors-1.5.1 branch October 4, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukecotter @sjonwilson @lcottercertinia