Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom colors for timeline from vscode prefs - v1.5.1 #166

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
46ad2c7
Implement breadcrumbs in the call tree (on click)
sjonwilson Jul 18, 2022
d10c2a4
Update change log
sjonwilson Jul 18, 2022
e4c402e
Exclude scroll-padding from call-tree clicks
sjonwilson Jul 25, 2022
7b6d6e4
Enhance breadcrumb text
sjonwilson Jul 29, 2022
c656bdd
Go to code on cmd-click
sjonwilson Jul 29, 2022
8bf84a3
Merge remote-tracking branch 'origin/main' into poc/breadcrumbs
sjonwilson Jul 29, 2022
18d2f81
Merge remote-tracking branch 'origin/main' into poc/breadcrumbs
sjonwilson Aug 1, 2022
918b4dc
Mend breadcrumb click
sjonwilson Aug 1, 2022
c9ba22f
Fix the changelog after merging in main
sjonwilson Aug 1, 2022
6ab49bd
ci(jest): add command to speed up tests in ci
lukecotter Aug 3, 2022
527908c
build(rollup): restrict files to compile
lukecotter Aug 3, 2022
6146f0e
build(ts): update target JS version to es2021
lukecotter Aug 3, 2022
ed31779
build(npm): remove babel
lukecotter Aug 4, 2022
9ac7a4c
chore(npm deps): update npm deps to latest compatible versions
lukecotter Aug 4, 2022
b20a311
chore(npm deps): update npm deps to latest major versions
lukecotter Aug 4, 2022
d139fa3
Merge branch 'main' into feat-typescript-improve-speed
lukecotter Aug 4, 2022
c95b516
Merge remote-tracking branch 'origin/main' into poc/breadcrumbs
sjonwilson Aug 9, 2022
d6033e9
refactor: remove circular dependency on Main.ts
lukecotter Aug 12, 2022
266d510
test: delete empty test class
lukecotter Aug 12, 2022
df91aa5
build(ts): additional typescript options enabled
lukecotter Aug 12, 2022
7e894a2
docs: update building md formatting
lukecotter Aug 12, 2022
76938e4
build: update watch to use rollup
lukecotter Aug 12, 2022
f2b07aa
feat: enable prettier-eslint formatting
lukecotter Aug 16, 2022
cc8a4e2
style: format all lana ts files with prettier
lukecotter Aug 16, 2022
3f5415b
style: format all log-viewer ts files with prettier
lukecotter Aug 16, 2022
c07c3b5
style: format all remaining files with prettier
lukecotter Aug 16, 2022
2d0d6f1
style: auto fix eslint issues in lana
lukecotter Aug 16, 2022
d5ae68f
refactor: apply eslint rule suggestions to lana
lukecotter Sep 1, 2022
a1fc45d
refactor: apply eslint rule suggestions to logviewer
lukecotter Sep 1, 2022
47b6ec3
refactor: default duration to 0
lukecotter Sep 1, 2022
fea118d
refactor: remove unused events (eslint warnings)
lukecotter Sep 1, 2022
67bb7bc
refactor: move imports from main to lit components that need them
lukecotter Sep 2, 2022
e83a503
refactor: use interface for type when setting timeline colours
lukecotter Sep 2, 2022
665b53c
refactor: remove implict non null asertion on canvas context
lukecotter Sep 2, 2022
24233a4
refactor: enable use of _ to mark function args as not used eslint
lukecotter Sep 2, 2022
f11415b
refactor: remove unused class
lukecotter Sep 2, 2022
00c32c4
refactor: default self time to 0 insead of null
lukecotter Sep 2, 2022
beefd6e
Code review changes
sjonwilson Sep 2, 2022
ac34bb4
Update CHANGELOG.md
sjonwilson Sep 2, 2022
bc508e0
Update CHANGELOG.md
sjonwilson Sep 2, 2022
efba95d
Merge pull request #154 from lukecotter/feat-153-prettier-eslint-rules
lcottercertinia Sep 5, 2022
1b7fcda
Merge branch 'main' into feat-153-fix-eslint-errors
lukecotter Sep 5, 2022
b04201c
Merge pull request #155 from lukecotter/feat-153-fix-eslint-errors
lcottercertinia Sep 5, 2022
26e5efd
Merge remote-tracking branch 'origin/main' into poc/breadcrumbs
sjonwilson Sep 5, 2022
21451c1
Remove redundant @ts-ignore lines
sjonwilson Sep 5, 2022
a04711a
Merge branch 'main' into feat-156-typescript-improve-speed
lukecotter Sep 5, 2022
9cea60d
Run prettier
sjonwilson Sep 5, 2022
b2b6720
Allow CTRL-click for windows users
sjonwilson Sep 6, 2022
b2f2b8b
Merge pull request #143 from financialforcedev/poc/breadcrumbs
lcottercertinia Sep 6, 2022
2fa1011
Merge branch 'main' into feat-156-typescript-improve-speed
lukecotter Sep 7, 2022
9d930ff
build: enable isolated modules
lukecotter Sep 23, 2022
f823a92
Merge pull request #157 from lukecotter/feat-156-typescript-improve-s…
lcottercertinia Sep 23, 2022
b7d2ec6
fix: custom colors for timeline from vscode prefs
lukecotter Oct 4, 2022
7ee1c69
chore: bump version to v1.5.1
lukecotter Oct 4, 2022
74f7510
Merge branch 'main' into bug-163-fix-custom-timeline-colors-1.5.1
lukecotter Oct 4, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ jobs:
run: |
cd log-viewer
npm ci
npm run test
npm run test:ci
4 changes: 3 additions & 1 deletion .prettierrc
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
{
"tabWidth": 2,
"printWidth": 100
"printWidth": 100,
"semi": true,
"singleQuote": true
}
36 changes: 20 additions & 16 deletions BUILDING.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,22 @@
# Getting Started

The extension source code is written in [TypeScript](https://www.typescriptlang.org/). This is compiled into Javascript as part of the build process. To re-build from source install the prerequisites and then follow the building instructions.
The extension source code is written in [TypeScript](https://www.typescriptlang.org/). This is compiled into Javascript as part of the build process. To re-build from source install the prerequisites and then follow the building instructions.

The lana directory contain the extension source code. The log-viewer directory contains the source code for the webview displayed by the extension. This includes the code to parse log files and display data such as the flamegraph.

## Prerequisites
## Prerequisites

### Node.js v12 or above ([node](https://nodejs.org/en/))
### Node.js v16 or above ([node](https://nodejs.org/en/))

### VS Code Extension Manager ([vsce](https://github.com/microsoft/vscode-vsce))

VSCE is only required to create .vsix files for distribution. It can be installed globally with

```sh
npm i -g vsce
```

# Development
## Development

To build use:

Expand All @@ -38,28 +39,31 @@ tsc -p ./

Once compiled you can launch the extension directly from VSCode using the 'Run Extension' launch configuration.

# Local Development (lana extension)
## Local Development (lana extension)

The extension can be debugged in VSCode, to do this:

cd lana
npm ci
npm run compile

```zsh
cd lana
npm ci
npm run compile
```

This will compile the extension. The you can use the "Run Extension' debug configuration to have VSCode launch another version of VSCode with the current extension enabled.
This will compile the extension. The you can use the "Run Extension' debug configuration to have VSCode launch another version of VSCode with the current extension enabled.

# Local Development (log-viewer)
## Local Development (log-viewer)

The log-viewer can be run in a web browser to speed development work. To do this:

cd log-viewer
npm ci
npm run debug
```zsh
cd log-viewer
npm ci
npm run debug
```

This will start a web server that you can access from any browser alongside a watch process that will recompile when source files are changed. The URL for the server is shown on the console. Use the "Launch Chrome' debug configuration to have VSCode launch and attach to Chrome for debugging.
This will start a web server that you can access from any browser alongside a watch process that will recompile when source files are changed. The URL for the server is shown on the console. Use the "Launch Chrome' debug configuration to have VSCode launch and attach to Chrome for debugging.

# Packaging
## Packaging

You can package the extension using:

Expand Down
18 changes: 18 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,22 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased

## Added

- Breadcrumbs shown above the calltree when clicking a row ([#142][#142])

### Changed

- Goto code from click to CMD/CTRL and click. Breadcrumbs are shown on click instead. ([#142][#142])

## [1.5.1] - 2022-10-04

### Fixed

- Fixes custom timeline event colors not being used from vscode preferences ([#163][#163])

## [1.5.0] - 2022-08-08

## Added
Expand Down Expand Up @@ -159,3 +175,5 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#135]: https://github.com/financialforcedev/debug-log-analyzer/issues/135
[#139]: https://github.com/financialforcedev/debug-log-analyzer/issues/139
[#23]: https://github.com/financialforcedev/debug-log-analyzer/issues/23
[#142]: https://github.com/financialforcedev/debug-log-analyzer/issues/142
[#163]: https://github.com/financialforcedev/debug-log-analyzer/issues/163
38 changes: 21 additions & 17 deletions lana/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,19 +1,23 @@
{
"root": true,
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": 6,
"sourceType": "module"
},
"plugins": [
"@typescript-eslint"
],
"rules": {
"@typescript-eslint/naming-convention": "warn",
"@typescript-eslint/semi": "warn",
"curly": "warn",
"eqeqeq": "warn",
"no-throw-literal": "warn",
"semi": "off"
}
"root": true,
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": "latest",
"sourceType": "module"
},
"plugins": ["@typescript-eslint", "prettier"],
"extends": [
"eslint:recommended",
"plugin:@typescript-eslint/eslint-recommended",
"plugin:@typescript-eslint/recommended",
"prettier"
],
"rules": {
"no-console": "warn",
"prettier/prettier": "error",
"@typescript-eslint/naming-convention": "warn",
"@typescript-eslint/semi": "warn",
"curly": "warn",
"eqeqeq": "warn"
}
}
6 changes: 6 additions & 0 deletions lana/.prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"tabWidth": 2,
"printWidth": 100,
"semi": true,
"singleQuote": true
}
Loading