Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLMOVE is also used with clients not supporting it, resulting in broken pipeline #2233

Closed
wagner-intevation opened this issue Aug 8, 2022 · 0 comments · Fixed by #2240
Closed

BLMOVE is also used with clients not supporting it, resulting in broken pipeline #2233

wagner-intevation opened this issue Aug 8, 2022 · 0 comments · Fixed by #2240
Labels
bug Indicates an unexpected problem or unintended behavior
Milestone
3.1.0

Comments

@wagner-intevation
Copy link
Contributor 

2022-08-08T14:46:59.313000 - deduplicator-expert - INFO - Bot will continue in 15 seconds.
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/intelmq/lib/pipeline.py", line 267, in _receive
    retval = self.pipe.blmove(self.source_queue, self.internal_queue, 0, 'RIGHT', 'LEFT')
AttributeError: 'Redis' object has no attribute 'blmove'

Server version is 7.0.2, but the python library is 3.3.11. BLMOVE is first available in 4.0.0 (and 4.1.2 fixed a major bug redis/redis-py#1776).
@sebix sebix added the bug Indicates an unexpected problem or unintended behavior label Aug 8, 2022
@sebix sebix added this to the 3.1.0 milestone Aug 8, 2022
@sebix sebix changed the title BLMOVE is also used with clients not supporting it, resulting in BLMOVE is also used with clients not supporting it, resulting in broken pipeline Aug 8, 2022
sebix pushed a commit that referenced this issue Aug 31, 2022
@wagner-intevation
BUG: lib/pipeline: use blmove only if redis-py supports it
4ac457b 
BRLPOPLPUSH is deprecated, but BLMOVE can only be used if the redis
python client does support it, ie. >= 4.1.2

fixes #2233
@wagner-intevation wagner-intevation mentioned this issue Aug 31, 2022
Merged
sebix pushed a commit that referenced this issue Dec 22, 2022
@wagner-intevation @sebix
BUG: lib/pipeline: use blmove only if redis-py supports it
345f879 
BRLPOPLPUSH is deprecated, but BLMOVE can only be used if the redis
python client does support it, ie. >= 4.1.2

fixes #2233
sebix pushed a commit that referenced this issue Dec 22, 2022
@wagner-intevation
BUG: lib/pipeline: use blmove only if redis-py supports it
c5f531e 
BRLPOPLPUSH is deprecated, but BLMOVE can only be used if the redis
python client does support it, ie. >= 4.1.2

fixes #2233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

BUG: lib/pipeline: use blmove only if redis-py supports it certtools/intelmq
3 participants
@sebix @waldbauer-certat @wagner-intevation