Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: lib/pipeline: use blmove only if redis-py supports it #2240

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

wagner-intevation
Copy link
Contributor

BRLPOPLPUSH is deprecated, but BLMOVE can only be used if the redis
python client does support it, ie. >= 4.1.2

fixes #2233

BRLPOPLPUSH is deprecated, but BLMOVE can only be used if the redis
python client does support it, ie. >= 4.1.2

fixes #2233
@sebix sebix added this to the 3.1.0 milestone Dec 23, 2022
@sebix sebix added bug Indicates an unexpected problem or unintended behavior component: core labels Dec 23, 2022
@wagner-intevation
Copy link
Contributor Author

@kamil-certat could you please review this PR?

Copy link
Member

@aaronkaplan aaronkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, reviewed. looks good! Thanks for the contribution :)

@aaronkaplan aaronkaplan merged commit 264d669 into develop Feb 2, 2023
@sebix sebix deleted the fix-2233 branch February 2, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BLMOVE is also used with clients not supporting it, resulting in broken pipeline
3 participants