Add collaborators #264
Closed
Add collaborators #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarioRodrigues10
requested review from
feliciofilipe,
ruioliveira02 and
ruilopesm
MarioRodrigues10
force-pushed
the
mr/add-collaborators
branch
from
c180f09
to
73816ce
Compare
MarioRodrigues10
force-pushed
the
mr/add-collaborators
branch
from
73816ce
to
6642fe0
Compare
ruioliveira02
requested changes
Jan 25, 2023
|
|
||
| @required_fields ~w(collaborator_id department_id)a | ||
|
|
||
| schema "collaborator_departments" do |
There was a problem hiding this comment.
Should we not have a role to identify this relation, e.g.: 'President', 'Vice-President', etc?
There was a problem hiding this comment.
I thought about creating another schema "board_users" where i give those roles to an user
There was a problem hiding this comment.
Inside this schema i can create role field and give it to user , what you think?
|
We need to discuss this carefully before going forward |
ruilopesm
reviewed
Jul 3, 2023
Co-authored-by: Rui Lopes <76881129+RuiL1904@users.noreply.github.com>
| create table(:collaborator_departments, primary_key: false) do | ||
| add :id, :binary_id, primary_key: true | ||
|
|
||
| add :collaborator_id, references(:users, on_delete: :nothing, type: :binary_id) |
There was a problem hiding this comment.
Suggested change
| add :collaborator_id, references(:users, on_delete: :nothing, type: :binary_id) | |
| add :user_id, references(:users, on_delete: :nothing, type: :binary_id) |
| @required_fields ~w(collaborator_id department_id)a | ||
|
|
||
| schema "collaborator_departments" do | ||
| belongs_to :collaborator, User |
There was a problem hiding this comment.
Suggested change
| belongs_to :collaborator, User | |
| belongs_to :user, User |
|
This was closed because it was done in #291 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.