Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layout #291

Merged
merged 28 commits into from
Aug 10, 2023
Merged

Add layout #291

merged 28 commits into from
Aug 10, 2023

Conversation

MarioRodrigues10
Copy link
Member

@MarioRodrigues10 MarioRodrigues10 commented Jul 15, 2023

There's a few things missing in this PR:

  • Board index page
  • Partner show page
  • User settings page
  • Change pages config by role in organization
  • Organizations index page
  • Add a field session_image to an actitivity session
  • Add a field logo to an organization
  • Fix mobile layout in some pages
  • Add news
  • Add a field description to a department
  • Add a layout to forms
  • Fix scanner by role
  • Change sidebar depending on user role in an organization
  • Fix activities , use (sessions) instead
  • Add hook to change default_organization on click (basically now the organization tab is a live_component)
  • Add collaborators (many to many user / departments)

lib/atomic_web.ex Outdated Show resolved Hide resolved
Copy link
Member

@ruioliveira02 ruioliveira02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
A couple of things:

  1. On the top left below "CeSIUM" the role shows up as "role". I don't know if you forgot or weren't planning on doing it now, but I think it should be done in this PR
  2. I am not a fan of the mobile design. I think we can remove the organization part on top. It is taking up valuable space. When the hamburger menu is clicked, the navbar should take up the entire screen (like we do in CoderDojo Braga, and integrate the organization there
  3. We need to add logos for organizations

lib/atomic/organizations.ex Outdated Show resolved Hide resolved
@MarioRodrigues10 MarioRodrigues10 marked this pull request as draft August 5, 2023 15:05
@MarioRodrigues10 MarioRodrigues10 marked this pull request as ready for review August 9, 2023 21:19
@MarioRodrigues10
Copy link
Member Author

Although there's an item not done, i made this ready for review , because a member of our team said he wanted to take care of that issue.

lib/atomic/accounts/course.ex Outdated Show resolved Hide resolved
lib/atomic/activities.ex Show resolved Hide resolved
lib/atomic/activities/session.ex Show resolved Hide resolved
lib/atomic/organizations.ex Outdated Show resolved Hide resolved
lib/atomic/organizations/collaborator.ex Show resolved Hide resolved
lib/atomic_web/live/membership_live/index.ex Outdated Show resolved Hide resolved
lib/atomic_web/live/membership_live/show.ex Outdated Show resolved Hide resolved
lib/atomic_web/live/membership_live/show.ex Outdated Show resolved Hide resolved
lib/atomic_web/live/partner_live/index.ex Outdated Show resolved Hide resolved
lib/atomic_web/live/scanner_live/index.ex Show resolved Hide resolved
Copy link
Member

@ruilopesm ruilopesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work 🚀

@MarioRodrigues10 MarioRodrigues10 merged commit 4812687 into develop Aug 10, 2023
2 checks passed
@MarioRodrigues10 MarioRodrigues10 deleted the mr/add-layout branch August 10, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants