This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Make compatible with apache/nifi >= 1.19.0 (#313) #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jannik Rebmann <jannik.rebmann@ise.fraunhofer.de>
|
I just took a look at it. I don't think the build fails because of my change. The unit test Is the problem already known? |
|
yeah, not sure what's wrong. #319 did not have an issue with the tests, is this PR still relevant? |
|
Absolutely! This PR is essential to use Apache NiFi versions >=1.19.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request allows
apache/nifiversions>=0.19.0to be released with this helm chart.As described in issue #313, this only required the keystore type to be explicitly set to
JKSwhen callingkeytoolto be compatible with Java 11.This change is backward compatible with Java 8.
Which issue this PR fixes
apache/nifi >= 1.19.0#313Checklist