Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nifi-registry] Made compatible with apache/nifi >= 1.19.0 #285

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

jrebmann
Copy link
Contributor

@jrebmann jrebmann commented Feb 7, 2024

This bugfix is completely analogous to the pull request cetic/helm-nifi#314.

This pull request allows apache/nifi-registry versions >=0.19.0 to be released with this helm chart.

As described in issue cetic/helm-nifi#313, this only required the keystore type to be explicitly set to JKS when calling keytool to be compatible with Java 11.

This change is backward compatible with Java 8.

@VladStarr
Copy link
Contributor

@jrebmann
Thank you for the fix 🙂

Can you please bump the chart version so we can merge this PR into main?

@jrebmann
Copy link
Contributor Author

@VladStarr Thank you for reviewing my pull request :)

I have upgraded the version to 1.1.5 because it is fully backward compatible with previous versions of nif-registry.
If you want to open a feature version with this change, just let me know.

@VladStarr VladStarr merged commit 9623699 into dysnix:main Feb 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants