Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bzlmod #195

Closed
20 of 21 tasks
cgrindel opened this issue Jan 13, 2023 · 1 comment
Closed
20 of 21 tasks

Support bzlmod #195

cgrindel opened this issue Jan 13, 2023 · 1 comment
Assignees
@cgrindel
Labels
chore Developer clean up or refactor

Comments

@cgrindel
Copy link
Owner

cgrindel commented Jan 13, 2023 •
edited
Loading

Tasks
@cgrindel cgrindel added the chore Developer clean up or refactor label Jan 13, 2023
@cgrindel cgrindel self-assigned this Jan 13, 2023
@cgrindel cgrindel mentioned this issue Mar 8, 2023
Merged
cgrindel added a commit that referenced this issue Mar 8, 2023
@cgrindel
chore: add support for bzlmod (#232)
c3fde70 
- Clean house:
  - Remove all conditional dependency code.
- Remove the ability to build buildtools from source. Just use
`keith/buildifier-prebuilt`.
  - Remove unused `binary_pkg`.
- Add `MODULE.bazel` with all dependencies.
- Update all example workspaces to include a `MODULE.bazel`.
- Add `--noenable_bzlmod` to `shared.bazelrc` until
bazelbuild/bazel#14140 is fixed.

Related to #195.
@cgrindel cgrindel mentioned this issue Mar 8, 2023
Merged
cgrindel added a commit that referenced this issue Mar 8, 2023
@cgrindel
chore: add CI tests with and without bzlmod enabled (#233)
5962eab 
- Upgrade runners to macos-12 and ubuntu-22.04.
- Add matrix jobs for running examples with and without bzlmod enabled.

Related to #195.
@cgrindel cgrindel mentioned this issue Mar 8, 2023
Merged
cgrindel added a commit that referenced this issue Mar 9, 2023
@cgrindel
chore: add bzlmod_e2e in preparation for publishing to BCR (#234)
fe93c39 
- Add `examples/bzlmod_e2e` child workspace as test for publish_to_bcr
presubmit.
- Add `.bcr` files for public_to_bcr.

Related to #195.
@cgrindel cgrindel mentioned this issue Mar 9, 2023
Merged
cgrindel added a commit that referenced this issue Mar 9, 2023
@cgrindel
fix: set MODULE.bazel version to 0.0.0 and fix download URL (#237)
93cfa28 
Related to #195.
@cgrindel cgrindel mentioned this issue Mar 9, 2023
Merged
cgrindel added a commit that referenced this issue Mar 9, 2023
@cgrindel
chore: introduce strict bzlmod by adding WORKSPACE.bzlmod (#238)
56de025 
- Add `WORKSPACE.bzlmod` to all workspaces to ensure that the strict
bzlmod support was enabled.
- Disable all documentation generation and tests until
bazelbuild/bazel#14140 is fixed.
- Update CI to execute tidy and test with and without bzlmod.
- Fix warning in `sorted_genquery.bzl`.

Related to #195.
@cgrindel cgrindel mentioned this issue Mar 9, 2023
Merged
cgrindel added a commit that referenced this issue Mar 9, 2023
@cgrindel
fix: include examples/bzlmod_e2e in release archive (#240)
a2a40ca 
- Add the E2E test in the release archive.
- Set the `strip-prefix` to an empty string. We do not have a prefix to
be stripped in our release archive.
- Remove git stuff.

Related to #195.
@cgrindel cgrindel mentioned this issue Mar 9, 2023
Merged
cgrindel added a commit that referenced this issue Mar 9, 2023
@cgrindel
fix: update metadata for BCR to include OWNER and REPO (#242)
787dc8d 
Related to #195.
@cgrindel cgrindel mentioned this issue Mar 10, 2023
Merged
cgrindel added a commit that referenced this issue Mar 10, 2023
@cgrindel
fix: use minimal .bazelrc in bzlmod_e2e workspace (#244)
399d1ff 
Related to #195
@cgrindel cgrindel mentioned this issue Mar 10, 2023
Merged
cgrindel added a commit that referenced this issue Mar 10, 2023
@cgrindel
chore: add debug code to buildifier.sh (#246)
ec411c1 
Trying to debug [error on BCR CI
machines](https://buildkite.com/bazel/bcr-presubmit/builds/1101#0186c91f-7ac0-4d98-8f29-2a9e4623948e).
Related to #195.
@cgrindel cgrindel mentioned this issue Mar 10, 2023
Merged
cgrindel added a commit that referenced this issue Mar 10, 2023
@cgrindel
fix: switch to runfiles.bash v3 (#249)
a33854d 
The Bash runfiles have been updated to support repo mapping.
Related to #195.
@cgrindel cgrindel mentioned this issue Mar 10, 2023
Merged
cgrindel added a commit that referenced this issue Mar 10, 2023
@cgrindel
chore: add more debug code to buildifier.sh (#252)
647d85d 
Related to #195.
@cgrindel cgrindel mentioned this issue Mar 10, 2023
Merged
cgrindel added a commit that referenced this issue Mar 10, 2023
@cgrindel
chore: more debug for buildifier.sh (#254)
de396ce 
Related to #195.
@cgrindel cgrindel mentioned this issue Mar 11, 2023
Merged
cgrindel added a commit that referenced this issue Mar 11, 2023
@cgrindel
chore: add bazel_compatibility to module (#256)
7ab5dcb 
- Remove debug code in `buildifier.sh`.

Related to #195.
@cgrindel cgrindel mentioned this issue Mar 14, 2023
Merged
cgrindel added a commit that referenced this issue Mar 14, 2023
@cgrindel
chore: mark stardoc doc generation targets as incompatible with bzlmod (
a0da134 
#258)

- Add `//bzlmod:enabled` flag.
- Add `//bzlmod:is_enabled` config setting.
- Mark stardoc rule generation as being incompatible with bzlmod.
- Added Gazelle directives to ignore child workspaces.
- Enable bzlmod by default in `shared.bazelrc`.
- Uncommented the doc generation build files.

Related to #195.
@cgrindel cgrindel mentioned this issue Mar 16, 2023
Merged
cgrindel added a commit that referenced this issue Mar 16, 2023
@cgrindel
chore: use rules_bazel_integration_test module (#263)
6924b16 
Related to #195.
@cgrindel
Copy link
Owner Author

Tracking remaining items in other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgrindel cgrindel

Labels
chore Developer clean up or refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cgrindel