Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Go SDK reference in MODULE.bazel #248

Closed
Tracked by #195
cgrindel opened this issue Mar 10, 2023 · 0 comments · Fixed by #250
Closed
Tracked by #195

Fix the Go SDK reference in MODULE.bazel #248

cgrindel opened this issue Mar 10, 2023 · 0 comments · Fixed by #250
Labels
bug Something isn't working

Comments

@cgrindel
Copy link
Owner

bazelbuild/bazel-central-registry#498 (comment)

The next version of rules_go will disallow specifying SDK names from non-root modules. rules_go always provides the go_default_sdk repo via this extension which you can use without adding a tag. Sorry for the inconvenience, we are still trying to get the API just right.
@cgrindel cgrindel added the bug Something isn't working label Mar 10, 2023
This was referenced Mar 10, 2023
Closed
Closed
Merged
cgrindel added a commit that referenced this issue Mar 10, 2023
@cgrindel
fix: update MODULE.bazel to use go_default_sdk (#250)
888a680 
Alias the `go_default_sdk` to be `go_sdk` so that we can support with
and without bzlmod enabled.

Closes #248.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update MODULE.bazel to use go_default_sdk cgrindel/bazel-starlib
1 participant
@cgrindel