Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstring to ALE and fix seed range #234

Merged
merged 3 commits into from
Feb 15, 2018
Merged

Conversation

muupan
Copy link
Member

@muupan muupan commented Feb 13, 2018

No description provided.

Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except a line

game (str): Name of a game. You can get the complete list of supported
games by calling atari_py.list_games().
seed (int or None): If set to an int, it is used as a random seed for
the ALE. It must be in [0, 2 ** 16). If set to None, numpy's random
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[0, 2 ** 31)

@muupan
Copy link
Member Author

muupan commented Feb 15, 2018

Thank you, I fixed it.

Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muupan muupan merged commit 60518af into chainer:master Feb 15, 2018
@muupan muupan deleted the ale-fix-seed2 branch February 15, 2018 04:20
@muupan muupan added this to the v0.4 milestone Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants