Improve random seed setting in ALE examples #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muupan
changed the title
toslunar
reviewed
Feb 15, 2018
examples/ale/train_a3c_ale.py
Outdated
| # Set different random seeds for different subprocesses. | ||
| # If seed=0 and processes=4, subprocess seeds are [0, 1, 2, 3]. | ||
| # If seed=1 and processes=4, subprocess seeds are [4, 5, 6, 7]. | ||
| assert (args.seed + 1) * args.processes < 2 ** 31 |
There was a problem hiding this comment.
The check would be assert (args.seed + 1) * args.processes - 1 < 2 ** 31. It might be clearer to check it by process_seeds.max() < 2 ** 31.
|
Thank you for the review. I fixed the boundary check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #234 first.
This PR improves default random seed settings in
examples/ale/train_dqn_ale.pyandexamples/ale/train_a3c_ale.pyso that they are deterministic by default.If this is merged, then I'll update other examples as well in another PR.