Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning about numpy 1.16.0 #476

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Add warning about numpy 1.16.0 #476

merged 1 commit into from
Jun 12, 2019

Conversation

muupan
Copy link
Member

@muupan muupan commented Jun 11, 2019

Resolves #475

prabhatnagarajan
prabhatnagarajan reviewed Jun 11, 2019
View reviewed changes
Copy link
Contributor

@prabhatnagarajan prabhatnagarajan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this? I.e. have you checked whether the warning indeed is generated for a specific python version (not necessarily the one in this PR)?

@muupan
Copy link
Member Author

muupan commented Jun 11, 2019

yes

@prabhatnagarajan prabhatnagarajan self-assigned this Jun 11, 2019
toslunar
toslunar reviewed Jun 11, 2019
View reviewed changes
chainerrl/envs/multiprocess_vector_env.py
@@ -53,6 +54,13 @@ class MultiprocessVectorEnv(chainerrl.env.VectorEnv):
"""

def __init__(self, env_fns):
if np.__version__ == '1.16.0':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, numpy.lib.NumpyVersion could be used. Looks OK without it to detect a single version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intend to detect a single version. I haven't check if pre-release versions of numpy have the same issue.

@prabhatnagarajan prabhatnagarajan merged commit 98c3c8a into chainer:master Jun 12, 2019
@muupan muupan deleted the warn-numpy-1.16.0 branch June 13, 2019 01:15
@muupan muupan added this to the v0.7 milestone Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toslunar toslunar toslunar left review comments

@prabhatnagarajan prabhatnagarajan prabhatnagarajan approved these changes

Assignees

@prabhatnagarajan prabhatnagarajan

Labels
enhancement
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

Warn if numpy is 1.16.0
3 participants
@muupan @toslunar @prabhatnagarajan