Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning about numpy 1.16.0 #476

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Add warning about numpy 1.16.0 #476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions chainerrl/envs/multiprocess_vector_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from multiprocessing import Pipe
from multiprocessing import Process
import signal
import warnings

from cached_property import cached_property
import numpy as np
Expand Down Expand Up @@ -53,6 +54,13 @@ class MultiprocessVectorEnv(chainerrl.env.VectorEnv):
"""

def __init__(self, env_fns):
if np.__version__ == '1.16.0':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, numpy.lib.NumpyVersion could be used. Looks OK without it to detect a single version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intend to detect a single version. I haven't check if pre-release versions of numpy have the same issue.

warnings.warn("""
NumPy 1.16.0 can cause severe memory leak in chainerrl.envs.MultiprocessVectorEnv.
We recommend using other versions of NumPy.
See https://github.com/numpy/numpy/issues/12793 for details.
""") # NOQA

nenvs = len(env_fns)
self.remotes, self.work_remotes = zip(*[Pipe() for _ in range(nenvs)])
self.ps = \
Expand Down