This repository has been archived by the owner on Sep 25, 2021. It is now read-only.
Super patch #739
Merged
Super patch #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reimplemented post date - Added option for a 1-tap post info button, rather than a 2 tap button
- Moved strings to strings.xml - Removed superfluous imports from ThreadPresenter.java
Implement video auto-loop option
…enter is errored
…umb by checkstyle i hate it 0/10
…ctly scroll to the post in the fragment of the URL
…ere being two post linkables, but one of them not being a spoiler link
…etter results; refactors to not use iterators because why????
…etter results; iterators are used to prevent duplicates in the search I understand now
…into super-patch Fixes me being dumb # Conflicts: # Clover/app/src/main/java/org/floens/chan/ui/helper/BoardHelper.java
Clover/app/src/main/java/org/floens/chan/core/presenter/ThreadPresenter.java
Outdated
Show resolved
Hide resolved
Clover/app/src/main/java/org/floens/chan/ui/view/MultiImageView.java
Outdated
Show resolved
Hide resolved
Clover/app/src/main/java/org/floens/chan/ui/controller/ImageViewerController.java
Show resolved
Hide resolved
Clover/app/src/main/java/org/floens/chan/ui/controller/MediaSettingsController.java
Outdated
Show resolved
Hide resolved
Clover/app/src/main/java/org/floens/chan/core/model/PostLinkable.java
Outdated
Show resolved
Hide resolved
… follow so I can just auto-format it in the IDE
…e animation to present the first image isn't finished playing would softlock the application; probably tied to an issue but I couldn't find it
|
Version of the app in F Droid is 1 year old and the 'dev builds' button on the website doesn't show the date thereof. Any way to get a build with this patch included? |
|
Unfortunately outside of building it yourself with Android Studio and sideloading it, not really. You may also run into signature conflicts depending on what you're sideloading, release or dev. If you're only running dev right now, building it and sideloading it as a release application would work as long as you don't have one of Floens' releases installed. |
…ation. Seen when attempting to view a 600 frame long, solid white, 10K x 10K GIF, which is ~88KB compressed, but is 400MB per frame uncompressed.
|
🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, this is a total merge of all the features I know for a fact that I submitted to Clover that I know are functioning bug-free entirely. They're essentially copied verbatim from the previous PR's I made. The rest of the features I submitted were definitely out-of-date with numerous issues; you can still look at the code for those PRs, but a number of them have had their code modified and if you want to pull them, take a look at Kuroba's code instead.
Fixes #700
Fixes #681
Fixes #685, possibly fixes #617?
Fixes #500
Fixes #484, possibly fixes #450?
Fixes #759
Fixes #744
Resolves #600
Resolves #286
Resolves #543
Resolves #526 a little more (5 mintes addition)
Resolves #437 with @alex-eyre's previous PR
Resolves #683
Fixes a silly issue I found where the error dialog in the multi image view would pop up when the side images failed, rather than only the center one.
Fixes an issue where external links opened in Clover would not correctly scroll to the specified post if the thread had been opened before in Clover.
Fixes an issue where the board menu search didn't give good results for prefix searches; i.e. searching
sowould not return /soc/ but instead return /hm/ and /hr/ (as those names containso)Fixes an issue noted in Adamantcheese#378 for text-only mode crashing the application when viewing the album and trying to go to a post.
Fixes an issue found in Kuroba that would let a preview file that was nulled out be tapped, crashing the application.
Fixes an issue to prevent a softlock from occurring when the image viewer is backed out of before the animation to present the first image isn't finished playing. Back actions are disabled until this occurs.
Fixes an issue with certain GIFs crashing the application when being viewed, as each uncompressed frame would be larger than certain Canvas implementations would allow. Noted with a 600 frame long, solid white, 10K x 10K GIF, which is ~88KB compressed, but each frame is 400MB when uncompressed.