Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deposition related tooltips #919

Open
Tracked by #479
junxini opened this issue Jul 24, 2024 · 6 comments
Open
Tracked by #479

Deposition related tooltips #919

junxini opened this issue Jul 24, 2024 · 6 comments
Assignees
@kne42
Labels
frontend P1 Should have
Milestone
sprint 9 (phase 4)

Comments

@junxini
Copy link
Contributor

junxini commented Jul 24, 2024 •
edited
Loading

@junxini junxini mentioned this issue Jul 24, 2024
Open
25 tasks
@junxini junxini added frontend P0 Must have labels Jul 24, 2024
@junxini
Copy link
Contributor Author

junxini commented Aug 6, 2024

@dgmccart could you confirm if the copy i've included in this ticket maps to the right rows in the source of truth here?

@junxini junxini added P1 Should have and removed P0 Must have labels Aug 6, 2024
@dgmccart
Copy link
Collaborator

dgmccart commented Aug 6, 2024

Here is the copy:

  1. Browse All Deposition page info icon next to Deposition - "Deposition: A collection of annotations contributed by the same author(s). Learn More."
  2. Browse All Datasets page info icon next to Datasets - "Dataset: Image files for tilt series, reconstructed tomograms, and annotation files for one sample type and experimental conditions. Learn More."
  3. On single deposition page, add tooltip to the "Deposition Data" table header
    tooltip copy: "List of datasets contributed to by this deposition."
  4. On annotation info panel, add tooltip to "Deposition Name" field
    tooltip copy: "Deposition: A collection of annotations contributed by the same author(s). Learn More."

@junxini
Copy link
Contributor Author

junxini commented Aug 6, 2024

Thanks Dannielle, i've updated the ticket above to include the latest copy

@ehoops-cz ehoops-cz mentioned this issue Sep 12, 2024
Merged
ehoops-cz added a commit that referenced this issue Sep 13, 2024
@ehoops-cz
feat: Descriptions of datasets and depositions. (#1134)
6f2d66f 
Related issue #919 

Adds a description for datasets and depositions.
Updates the section title from “Deposition Data” to “Datasets with
Deposition Data”.

<img width="1248" alt="Screenshot 2024-09-12 at 4 31 54 PM"
src="https://github.com/user-attachments/assets/2860003c-6836-4a4c-8d9b-082a7a7606c1">
<img width="1262" alt="Screenshot 2024-09-12 at 4 31 15 PM"
src="https://github.com/user-attachments/assets/ee7c9579-eeef-4557-ac57-5b3f176a000c">
<img width="1232" alt="Screenshot 2024-09-12 at 4 32 57 PM"
src="https://github.com/user-attachments/assets/3369865c-2c74-46c7-85eb-29023764e9ce">
@junxini junxini added this to the sprint 5 (phase 4) milestone Sep 23, 2024
@junxini
Copy link
Contributor Author

junxini commented Sep 23, 2024

@kne42 i will double check what is still needed for this ticket, i'll respond back once i take a look

@junxini
Copy link
Contributor Author

junxini commented Oct 2, 2024

@kne42, there were previously 3 tooltip locations. I removed one of them as it's replaced by the banner. I kept the other 2 as they are still relevant

@junxini
Copy link
Contributor Author

junxini commented Oct 2, 2024

@Janeece i think there was a decision coming out of UXR studies to update the table header to "Datasets with Deposition Data" as seen in the dev environment here :https://dev-depositions.cryoet.dev.si.czi.technology/depositions/10307

FYI so that master files can get updated at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kne42 kne42

Labels
frontend P1 Should have
Projects
None yet
Milestone
sprint 9 (phase 4)
Development

No branches or pull requests
3 participants
@kne42 @dgmccart @junxini