feat: config supports toggling HTTP and Stats servers on/off (#594) #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaw
force-pushed
the
main
branch
2 times, most recently
from
9df0211 to
45494f5
Compare
Not exactly sure what you're looking for... |
Yes. You could use |
Ack, done. Tests got a little bit of polish as well. |
Perfect! Could you put the test changes in a separate PR so that it doesn't get mixed up with the changes here? |
added 4 commits
November 21, 2024 10:13
This was inconsistent with the other servers.
The generic "waitforserver" has been renamed to "ensureserverrunning". This command now also takes an argument which denotes which environment variable to pick the port from. This is needed as the ports are randomized by the test.
This is useful on Windows where gcc is not always available.
…#594) To test this, tests added: `ensureservernotrunning [SERVICE_NAME]`
|
This was rebased and submitted in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behavior of the stats server and git server but I assume most people don't want that by default.
The ssh/http servers are most likely the primary ones?