Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support toggling servers on/off in configuration (#594) #612

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

jaw
Copy link
Contributor

@jaw jaw commented Dec 5, 2024

To test this, tests added the new function:

ensureservernotrunning [SERVICE_NAME]

(This supersedes the old pull request #600)

closes #594

@jaw jaw requested a review from aymanbagabas as a code owner December 5, 2024 15:26
@aymanbagabas
Copy link
Member

@jaw Could you rebase this PR onto main?

…#594)

To test this, tests added the new function:

  `ensureservernotrunning [SERVICE_NAME]`
@jaw jaw force-pushed the feat_toggle_servers_on_off branch from 0daad42 to daff8cd Compare December 6, 2024 22:02
@jaw
Copy link
Contributor Author

jaw commented Dec 6, 2024

Done.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 65.78947% with 13 lines in your changes missing coverage. Please review.

Project coverage is 51.79%. Comparing base (b06b555) to head (daff8cd).
Report is 93 commits behind head on main.

Files with missing lines Patch % Lines
cmd/soft/serve/server.go 56.66% 9 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
- Coverage   51.96%   51.79%   -0.17%     
==========================================
  Files         157      159       +2     
  Lines       13454    13559     +105     
==========================================
+ Hits         6991     7023      +32     
- Misses       5891     5967      +76     
+ Partials      572      569       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aymanbagabas aymanbagabas merged commit 069db27 into charmbracelet:main Dec 6, 2024
12 checks passed
aymanbagabas added a commit that referenced this pull request Dec 9, 2024
Fixes: 069db27 (feat: support toggling servers on/off in configuration (#594) (#612))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a config option to enable/disable git, http and stats
2 participants