Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use array spread to push multiple items to labelColors #6438

Closed
wants to merge 2 commits into from

Conversation

RobbieTheWagner
Copy link

I believe this should allow for arrays to be returned from labelColor. I have not tested it yet, but I am going to now.

@benmccann
Copy link
Contributor

I believe the spread operator does not work in IE11, which is a browser we support

@benmccann
Copy link
Contributor

Thanks for the PR. For now, I'm going to close this since it's failing the tests and incompatible with IE. Please feel free to reopen when those issues are addressed

@benmccann benmccann closed this Aug 12, 2019
@RobbieTheWagner
Copy link
Author

@benmccann do you guys not use babel?

@benmccann
Copy link
Contributor

No, we don't

@RobbieTheWagner
Copy link
Author

@benmccann any particular reason to not use it?

@benmccann
Copy link
Contributor

See #5787 (comment)

@RobbieTheWagner
Copy link
Author

@benmccann why not use Babel and just transpile to the targets you want? That comment seems to be concerned about browser support, which is totally doable with Babel.

I really need to be able to specify multiple label colors. I can return an array from the label callback, which gives me two labels in the tooltip, but then I have no way to specify different colors for them. I tried custom tooltips, but they never show up at all, not sure why.

@benmccann
Copy link
Contributor

See #6555 for discussion on babel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants