Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add babel plugin for rollup & transform code #6555

Merged
merged 2 commits into from
Oct 27, 2019

Conversation

etimberg
Copy link
Member

@etimberg etimberg commented Oct 6, 2019

Adds the babel rollup plugin to enable moving the codebase to ES6+.

I did not configure the preset targets yet. We can do that once we decide what exactly we want to support.

@benmccann
Copy link
Contributor

@etimberg I don't have any major objections to this since we already need to compile the code to run it, but I know that @simonbrunel had wanted to wait until v3. See #5787 (comment)

@etimberg
Copy link
Member Author

etimberg commented Oct 7, 2019

Perhaps we should leave this until after 2.9 and then make the next version v3? Seems like we've got a long list of stuff to do

@RobbieTheWagner
Copy link

Very much in favor of adding babel. There should be no reason we could not enable it now. It should not break anything. If things need no transpiling, it should be a noop.

@etimberg
Copy link
Member Author

@benmccann now that v2.9 is out, shall we merge this?

@benmccann
Copy link
Contributor

I think using a .browserslistrc is preferred over targets. What do you think about adding a .browserslistrc that just uses their defaults for now? I think you just create the file and put the word "defaults" in it.

"defaults" is defined as: https://github.com/browserslist/browserslist/blob/2fee1e4d7b1bae0214bbbef10d04087a2785dfd3/index.js#L429

@etimberg
Copy link
Member Author

@benmccann I added the .browserlistrc file & copied the defaults over.

@etimberg etimberg merged commit 1ac3a69 into chartjs:master Oct 27, 2019
@etimberg etimberg deleted the add-babel-plugin branch October 27, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants