chore: browser database name should contain a valid DevWorkspace identifier #273

vitaliy-guliy · 2023-09-08T08:45:03Z

What does this PR do?

Uses a real workspace identifier taken from env.DEVWORKSPACE_ID to form the name of browser-based database.

What issues does this PR fix?

How to test this PR?

When you are on the dashboard, open browser development console, go to Application. In the Storage section below expand IndexedDB and remove all the databases
Create a workspace with https://github.com/che-incubator/che-code/tree/vscode-web-state-db-identifier-test
open a terminal, show a read DEVWORKSPACE_ID

$ export | grep DEVWORKSPACE_ID

[1] ensure there is a database containing the ID at the end
go to the dasboard, delete workspace, create a workspace using the same URI
[2] check the workspace ID and check, that there is another database with this ID has been created

Browse URL must be the same for both workspaces.

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

github-actions · 2023-09-08T08:45:17Z

Click here to review and test in web IDE:

github-actions · 2023-09-08T09:55:21Z

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-273-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-273-dev-amd64

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

github-actions · 2023-09-11T11:34:58Z

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-273-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-273-dev-amd64

github-actions · 2023-09-11T21:42:41Z

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-273-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-273-dev-amd64

github-actions · 2023-09-11T21:43:55Z

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-273-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-273-dev-amd64

github-actions · 2023-09-12T13:44:42Z

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-273-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-273-dev-amd64

code/src/vs/workbench/services/workspaces/browser/che/devWorkspaceId.ts

azatsarynnyy · 2023-09-12T15:59:44Z

code/src/vs/workbench/services/workspaces/browser/workspaces.ts

@@ -30,5 +31,5 @@ export function getSingleFolderWorkspaceIdentifier(folderUri: URI): ISingleFolde
 }

 function getWorkspaceId(uri: URI): string {
-	return hash(window.location.href + uri.toString()).toString(16);
+	return getDevWorkspceId() || hash(uri.toString()).toString(16);


I noticed that using only DevWorkspaceID as a VS Code's Workspace ID will bring another problem.

Let's consider the situation when the user has a DevWorkspace with the Che-Code sources cloned, but she wants to open just a subfolder, e.g.: launcher. In such a case, these two different VS Code Workspaces (che-code and che-code/launcher) will share the same IndexedDB. This means the user will get the same stored state of VS Code (panels layout, opened files, etc.) in both workspaces which is not expected, probably.
WDYT @vitaliy-guliy ?

If we decide we should avoid such a situation I suggest generating a hash value from the DevWorkspace ID as well: hash(getDevWorkspceId() + uri.toString()).toString(16)

Ok, in this case we will definitely have the unique ID 😀

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

github-actions · 2023-09-13T17:23:15Z

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-273-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-273-dev-amd64

devstudio-release · 2023-09-14T09:46:04Z

Build 3.10 :: code_3.x/853: Console, Changes, Git Data

devstudio-release · 2023-09-14T09:46:34Z

Build 3.10 :: code_3.x/852: Console, Changes, Git Data

devstudio-release · 2023-09-14T09:48:58Z

Build 3.10 :: sync-to-downstream_3.x/4546: Console, Changes, Git Data

devstudio-release · 2023-09-14T09:49:37Z

Build 3.10 :: sync-to-downstream_3.x/4547: Console, Changes, Git Data

devstudio-release · 2023-09-14T12:10:56Z

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4340: Console, Changes, Git Data

devstudio-release · 2023-09-14T12:24:25Z

Build 3.10 :: push-latest-container-to-quay_3.x/3180: Console, Changes, Git Data

devstudio-release · 2023-09-14T12:26:56Z

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4341: Console, Changes, Git Data

devstudio-release · 2023-09-14T12:29:25Z

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4340:

code : 3.x :: Build 55334593 : quay.io/devspaces/code-rhel8:3.10-19
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/3180 triggered

devstudio-release · 2023-09-14T12:29:30Z

Build 3.10 :: code_3.x/853:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4546 triggered

devstudio-release · 2023-09-14T12:29:31Z

Build 3.10 :: update-digests_3.x/4228: Console, Changes, Git Data

devstudio-release · 2023-09-14T12:33:44Z

Build 3.10 :: operator-bundle_3.x/2028: Console, Changes, Git Data

devstudio-release · 2023-09-14T12:41:15Z

Build 3.10 :: push-latest-container-to-quay_3.x/3181: Console, Changes, Git Data

devstudio-release · 2023-09-14T12:43:19Z

Build 3.10 :: sync-to-downstream_3.x/4549: Console, Changes, Git Data

devstudio-release · 2023-09-14T12:44:35Z

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4341:

code : 3.x :: Build 55334655 : quay.io/devspaces/code-rhel8:3.10-20
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/3181 triggered

devstudio-release · 2023-09-14T12:44:37Z

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4342: Console, Changes, Git Data

devstudio-release · 2023-09-14T12:44:40Z

Build 3.10 :: code_3.x/852:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4547 triggered

devstudio-release · 2023-09-14T12:55:05Z

Build 3.10 :: push-latest-container-to-quay_3.x/3182: Console, Changes, Git Data

devstudio-release · 2023-09-14T13:00:40Z

Build 3.10 :: copyIIBsToQuay/1866: Console, Changes, Git Data

devstudio-release · 2023-09-14T13:01:48Z

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4342:

devspaces-operator-bundle : 3.x :: Build 55334804 : quay.io/devspaces/devspaces-operator-bundle:3.10-13
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/3182 triggered;
Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.10-20
- quay.io/devspaces/configbump-rhel8:3.10-5
- quay.io/devspaces/dashboard-rhel8:3.10-9
- quay.io/devspaces/devfileregistry-rhel8:3.10-14
- quay.io/devspaces/devspaces-rhel8-operator:3.10-3
- quay.io/devspaces/idea-rhel8:3.10-3
- quay.io/devspaces/pluginregistry-rhel8:3.10-3
- quay.io/devspaces/server-rhel8:3.10-4
- quay.io/devspaces/traefik-rhel8:3.10-3
- quay.io/devspaces/udi-rhel8:3.10-4
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.12.0-202308291001.p0.g94f3fde.assembly.stream
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.12.0-202308281924.p0.g03e5b13.assembly.stream
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.8-1037

devstudio-release · 2023-09-14T13:01:53Z

Build 3.10 :: sync-to-downstream_3.x/4549:

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/4342 triggered; /job/DS_CI/job/dsc_3.x triggered;

devstudio-release · 2023-09-14T13:01:55Z

Build 3.10 :: operator-bundle_3.x/2028:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4549 triggered

devstudio-release · 2023-09-14T13:03:39Z

Build 3.10 :: dsc_3.x/1334: Console, Changes, Git Data

devstudio-release · 2023-09-14T13:06:02Z

Build 3.10 :: update-digests_3.x/4228:

Detected new images: rebuild operator-bundle
* code; /DS_CI/operator-bundle_3.x/2028 triggered

devstudio-release · 2023-09-14T13:06:05Z

Build 3.10 :: update-digests_3.x/4229: Console, Changes, Git Data

devstudio-release · 2023-09-14T13:07:50Z

Build 3.10 :: update-digests_3.x/4229:

No new images detected: nothing to do!

devstudio-release · 2023-09-14T13:49:58Z

Build 3.10 :: copyIIBsToQuay/1866:

3.10
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.10-13
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.10-v4.14-575325-533291-s390x
  + quay.io/devspaces/iib:3.10-v4.14-s390x
  + quay.io/devspaces/iib:next-v4.14-s390x
  + quay.io/devspaces/iib:3.10-v4.13-575281-533286-s390x
  + quay.io/devspaces/iib:3.10-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.10-v4.12-575220-533281-s390x
  + quay.io/devspaces/iib:3.10-v4.11-575213-533277-s390x
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.10-v4.14-575325-533291-ppc64le
  + quay.io/devspaces/iib:3.10-v4.14-ppc64le
  + quay.io/devspaces/iib:next-v4.14-ppc64le
  + quay.io/devspaces/iib:3.10-v4.13-575281-533286-ppc64le
  + quay.io/devspaces/iib:3.10-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.10-v4.12-575220-533281-ppc64le
  + quay.io/devspaces/iib:3.10-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le
  + quay.io/devspaces/iib:3.10-v4.11-575213-533277-ppc64le
  + quay.io/devspaces/iib:3.10-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.10-v4.14-575325-533291-x86_64
  + quay.io/devspaces/iib:3.10-v4.14-x86_64
  + quay.io/devspaces/iib:next-v4.14-x86_64
  + quay.io/devspaces/iib:3.10-v4.13-575281-533286-x86_64
  + quay.io/devspaces/iib:3.10-v4.12-575220-533281-x86_64
  + quay.io/devspaces/iib:3.10-v4.11-575213-533277-x86_64

github-actions · 2023-09-14T18:41:31Z

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-273-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-273-dev-amd64

github-actions · 2023-09-14T20:39:06Z

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-273-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-273-dev-amd64

…tifier (#273) * feat: use DevWorkspace ID to form browser database identifier Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

…fier (#273) (#274) * fix: use DevWorkspace ID to form browser database identifier Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

vitaliy-guliy added 3 commits September 8, 2023 01:43

first steps

0ffcee9

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

feat: use DevWorkspace ID to form browser database identifier

b65d268

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

chore: revert back che-editor.yaml

24e63ff

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

vitaliy-guliy changed the title ~~chore: browser database should contain a valid DevWorkspace identifier~~ chore: browser database name should contain a valid DevWorkspace identifier Sep 8, 2023

chore: fix typo

f9469ec

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

vitaliy-guliy marked this pull request as ready for review September 11, 2023 10:22

vitaliy-guliy requested review from azatsarynnyy, RomanNikitenko and l0rd as code owners September 11, 2023 10:22

azatsarynnyy reviewed Sep 12, 2023

View reviewed changes

chore: fix typo

a8a5664

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

azatsarynnyy approved these changes Sep 13, 2023

View reviewed changes

vitaliy-guliy merged commit 5db8fd3 into main Sep 14, 2023
1 of 2 checks passed

vitaliy-guliy deleted the vscode-web-state-db-identifier branch September 14, 2023 09:42

vitaliy-guliy added a commit that referenced this pull request Sep 20, 2023

chore: browser database name should contain a valid DevWorkspace iden…

06b9b74

…tifier (#273) * feat: use DevWorkspace ID to form browser database identifier Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

vitaliy-guliy mentioned this pull request Sep 20, 2023

fix: browser database name should contain a valid DevWorkspace identifier #274

Merged

vitaliy-guliy added a commit that referenced this pull request Sep 21, 2023

fix: browser database name should contain a valid DevWorkspace identi…

c16e042

…fier (#273) (#274) * fix: use DevWorkspace ID to form browser database identifier Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

RomanNikitenko mentioned this pull request Oct 4, 2024

Move to npm #420

Open

3 tasks

chore: browser database name should contain a valid DevWorkspace identifier #273

chore: browser database name should contain a valid DevWorkspace identifier #273

Conversation

vitaliy-guliy commented Sep 8, 2023

What does this PR do?

What issues does this PR fix?

How to test this PR?

github-actions bot commented Sep 8, 2023 • edited Loading

github-actions bot commented Sep 8, 2023

github-actions bot commented Sep 11, 2023

github-actions bot commented Sep 11, 2023

github-actions bot commented Sep 11, 2023

github-actions bot commented Sep 12, 2023

azatsarynnyy Sep 12, 2023

Choose a reason for hiding this comment

vitaliy-guliy Sep 13, 2023

Choose a reason for hiding this comment

github-actions bot commented Sep 13, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

devstudio-release commented Sep 14, 2023

github-actions bot commented Sep 14, 2023

github-actions bot commented Sep 14, 2023

github-actions bot commented Sep 8, 2023 •

edited

Loading