Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: browser database name should contain a valid DevWorkspace identifier #274

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

vitaliy-guliy
Copy link
Contributor

@vitaliy-guliy vitaliy-guliy commented Sep 20, 2023

What does this PR do?

Cherry-pick of #273

What issues does this PR fix?

eclipse-che/che#22338

How to test

Follow the flow from the original pull request but create a workspace with repository https://github.com/che-incubator/che-code/tree/vscode-web-state-db-identifier-test

…tifier (#273)

* feat: use DevWorkspace ID to form browser database identifier

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
@github-actions
Copy link

github-actions bot commented Sep 20, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-274-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-274-dev-amd64

@vitaliy-guliy vitaliy-guliy marked this pull request as ready for review September 21, 2023 12:29
@l0rd
Copy link
Contributor

l0rd commented Sep 21, 2023

LGTM 👍

@vitaliy-guliy vitaliy-guliy changed the title chore: browser database name should contain a valid DevWorkspace identifier fix: browser database name should contain a valid DevWorkspace identifier Sep 21, 2023
@vitaliy-guliy vitaliy-guliy merged commit c16e042 into 7.74.x Sep 21, 2023
2 of 3 checks passed
@vitaliy-guliy vitaliy-guliy deleted the cherry-pick-of-pr273 branch September 21, 2023 15:14
@devstudio-release
Copy link

Build 3.9 :: code_3.9/3: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.9 :: update-digests_3.9/143: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: code_3.9/3: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.9/131 triggered

@devstudio-release
Copy link

Build 3.9 :: operator-bundle_3.9/62: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.9 :: sync-to-downstream_3.9/133: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.9/132 triggered; /job/DS_CI/job/dsc_3.9 triggered;

@devstudio-release
Copy link

Build 3.9 :: operator-bundle_3.9/62: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.9/133 triggered

@devstudio-release
Copy link

Build 3.9 :: copyIIBsToQuay/1928: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: update-digests_3.9/143: SUCCESS

Detected new images: rebuild operator-bundle
* code
* configbump; /DS_CI/operator-bundle_3.9/62 triggered

@devstudio-release
Copy link

Build 3.9 :: dsc_3.9/60: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: dsc_3.9/60: SUCCESS

3.9.0 CI

@devstudio-release
Copy link

Build 3.9 :: copyIIBsToQuay/1929: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: copyIIBsToQuay/1929: SUCCESS

3.9
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.9-290
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.9-v4.14-581728-533291-x86_64
  + quay.io/devspaces/iib:3.9-v4.14-x86_64
  + quay.io/devspaces/iib:latest-v4.14-x86_64
  + quay.io/devspaces/iib:3.9-v4.13-581701-533286-x86_64
  + quay.io/devspaces/iib:3.9-v4.13-x86_64
  + quay.io/devspaces/iib:latest-v4.13-x86_64
  + quay.io/devspaces/iib:3.9-v4.12-581663-533281-x86_64
  + quay.io/devspaces/iib:3.9-v4.12-x86_64
  + quay.io/devspaces/iib:latest-v4.12-x86_64
  + quay.io/devspaces/iib:3.9-v4.11-581625-533277-x86_64
  + quay.io/devspaces/iib:3.9-v4.11-x86_64
  + quay.io/devspaces/iib:latest-v4.11-x86_64
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.9-v4.14-581728-533291-s390x
  + quay.io/devspaces/iib:3.9-v4.14-s390x
  + quay.io/devspaces/iib:latest-v4.14-s390x
  + quay.io/devspaces/iib:3.9-v4.13-581701-533286-s390x
  + quay.io/devspaces/iib:3.9-v4.13-s390x
  + quay.io/devspaces/iib:latest-v4.13-s390x
  + quay.io/devspaces/iib:3.9-v4.12-581663-533281-s390x
  + quay.io/devspaces/iib:3.9-v4.12-s390x
  + quay.io/devspaces/iib:latest-v4.12-s390x
  + quay.io/devspaces/iib:3.9-v4.11-581625-533277-s390x
  + quay.io/devspaces/iib:3.9-v4.11-s390x
  + quay.io/devspaces/iib:latest-v4.11-s390x
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.9-v4.14-581728-533291-ppc64le
  + quay.io/devspaces/iib:3.9-v4.14-ppc64le
  + quay.io/devspaces/iib:latest-v4.14-ppc64le
  + quay.io/devspaces/iib:3.9-v4.13-581701-533286-ppc64le
  + quay.io/devspaces/iib:3.9-v4.13-ppc64le
  + quay.io/devspaces/iib:latest-v4.13-ppc64le
  + quay.io/devspaces/iib:3.9-v4.12-581663-533281-ppc64le
  + quay.io/devspaces/iib:3.9-v4.12-ppc64le
  + quay.io/devspaces/iib:latest-v4.12-ppc64le
  + quay.io/devspaces/iib:3.9-v4.11-581625-533277-ppc64le
  + quay.io/devspaces/iib:3.9-v4.11-ppc64le
  + quay.io/devspaces/iib:latest-v4.11-ppc64le

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-274-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-274-dev-amd64

1 similar comment
@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-274-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-274-dev-amd64

@devstudio-release
Copy link

Build 3.9 :: code_3.9/4: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.9 :: code_3.9/5: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.9 :: code_3.9/6: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.9 :: code_3.9/7: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.9 :: code_3.9/8: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.9 :: update-digests_3.9/258: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: code_3.9/8: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.9/191 triggered

@devstudio-release
Copy link

Build 3.9 :: operator-bundle_3.9/93: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.9 :: copyIIBsToQuay/2066: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: copyIIBsToQuay/2066: SUCCESS

3.9
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.9-320
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.9-v4.14-613390-533291-s390x
  + quay.io/devspaces/iib:3.9-v4.13-613385-533286-s390x
  + quay.io/devspaces/iib:3.9-v4.12-613380-533281-s390x
  + quay.io/devspaces/iib:3.9-v4.11-613620-533277-s390x
  + quay.io/devspaces/iib:3.9-v4.11-s390x
  + quay.io/devspaces/iib:3.9-v4.11-s390x
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.9-v4.14-613390-533291-ppc64le
  + quay.io/devspaces/iib:3.9-v4.13-613385-533286-ppc64le
  + quay.io/devspaces/iib:3.9-v4.12-613634-533281-ppc64le
  + quay.io/devspaces/iib:3.9-v4.12-ppc64le
  + quay.io/devspaces/iib:3.9-v4.12-ppc64le
  + quay.io/devspaces/iib:3.9-v4.11-613620-533277-ppc64le
  + quay.io/devspaces/iib:3.9-v4.11-ppc64le
  + quay.io/devspaces/iib:3.9-v4.11-ppc64le
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.9-v4.14-613390-533291-x86_64
  + quay.io/devspaces/iib:3.9-v4.13-613385-533286-x86_64
  + quay.io/devspaces/iib:3.9-v4.12-613634-533281-x86_64
  + quay.io/devspaces/iib:3.9-v4.12-x86_64
  + quay.io/devspaces/iib:3.9-v4.12-x86_64
  + quay.io/devspaces/iib:3.9-v4.11-613620-533277-x86_64
  + quay.io/devspaces/iib:3.9-v4.11-x86_64
  + quay.io/devspaces/iib:3.9-v4.11-x86_64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants