fix(operator): fix deploying on K8s with operator and TLS #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
benoitf
reviewed
Aug 2, 2019
rhopp
reviewed
Aug 2, 2019
src/api/kube.ts
Outdated
| @@ -759,6 +759,9 @@ export class KubeHelper { | |||
| yamlCr.spec.server.cheImageTag = imageAndTag.length === 2 ? imageAndTag[1] : 'latest' | |||
| yamlCr.spec.auth.openShiftoAuth = flags['os-oauth'] | |||
| yamlCr.spec.server.tlsSupport = flags.tls | |||
| if (flags.tls) { | |||
| yamlCr.spec.k8s.tlsSecretName = `che-tls` | |||
There was a problem hiding this comment.
Where this che-tls value comes from?
What happens, if I put my own value in CheCluster YAML provided by parameter --che-operator-cr-yaml. To me it seems, that it will be overriden.
sleshchenko
requested review from
azatsarynnyy,
l0rd and
vparfonov
as code owners
l0rd
approved these changes
Aug 7, 2019
|
@sleshchenko FYI it doesn't work on CI (format style error) |
|
@benoitf Thanks! Fixed. |
sleshchenko
changed the title
rhopp
approved these changes
Aug 23, 2019
davidfestal
approved these changes
Aug 23, 2019
sleshchenko
changed the title
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix(operator): fix deploying on K8s with operator and TLS
What issues does this PR fix or reference?
eclipse-che/che#14102