Foodcritic not running correctly after installing 0.2.2 msi on windows 7

[poliva83]

Getting gem load error when trying to run foodcritic. I am under impression this should work after installing the msi.

C:\Users\poliva.RIMNET>foodcritic -h C:/Ruby200-x64/lib/ruby/2.0.0/rubygems/dependency.rb:296:in to_specs': Could no
t find 'foodcritic' (>= 0) among 9 total gem(s) (Gem::LoadError)
from C:/Ruby200-x64/lib/ruby/2.0.0/rubygems/dependency.rb:307:in to_spe c' from C:/Ruby200-x64/lib/ruby/2.0.0/rubygems/core_ext/kernel_gem.rb:47:in gem'
from C:/opscode/chefdk/bin/foodcritic:22:in `

'``

I tested kitchen berks chef-client chef-solo chef-apply commands and then all seem to be working fine.

[lamont-granquist]

Does chef exec foodcritic work?

[poliva83]

Does not appear so...

C:\Users\poliva.RIMNET>chef exec foodcritic C:/Ruby200-x64/lib/ruby/2.0.0/rubygems/dependency.rb:296:in to_specs': Could no
t find 'gherkin' (~> 2.11) - did find: [gherkin-2.12.2-x86-mingw32] (Gem::LoadEr
ror)
from C:/Ruby200-x64/lib/ruby/2.0.0/rubygems/specification.rb:1209:in bl ock in activate_dependencies' from C:/Ruby200-x64/lib/ruby/2.0.0/rubygems/specification.rb:1198:in ea
ch'
from C:/Ruby200-x64/lib/ruby/2.0.0/rubygems/specification.rb:1198:in ac tivate_dependencies' from C:/Ruby200-x64/lib/ruby/2.0.0/rubygems/specification.rb:1180:in ac
tivate'
from C:/Ruby200-x64/lib/ruby/2.0.0/rubygems/core_ext/kernel_gem.rb:48:in
gem' from C:/opscode/chefdk/bin/foodcritic:22:in

'`

[poliva83]

So I did have 2.0.0 ruby installed on my machine so I uninstalled it and removed old ruby from environment path.

I was then getting

C:\Users\poliva.RIMNET>foodcritic -h
'"ruby.exe"' is not recognized as an internal or external command,
operable program or batch file.

So I changed C:\opscode\chefdk\bin\foodcritic.bat to

@ECHO OFF
"%~dp0\..\embedded\bin\ruby.exe" "%~dpn0" %*

and then foodcritic works

C:\Users\poliva.RIMNET>foodcritic -h
foodcritic [cookbook_paths]
    -t, --tags TAGS                  Check against (or exclude ~) rules with the
 specified tags.
    -f, --epic-fail TAGS             Fail the build based on tags. Use 'any' to
fail on all warnings.
    -c, --chef-version VERSION       Only check against rules valid for this ver
sion of Chef.
    -B, --cookbook-path PATH         Cookbook path(s) to check.
    -C, --[no-]context               Show lines matched against rather than the
default summary.
    -E, --environment-path PATH      Environment path(s) to check.
    -I, --include PATH               Additional rule file path(s) to load.
    -G, --search-gems                Search rubygems for rule files with the pat
h foodcritic/rules/**/*.rb
    -R, --role-path PATH             Role path(s) to check.
    -S, --search-grammar PATH        Specify grammar to use when validating sear
ch syntax.
    -V, --version                    Display the foodcritic version.
    -X, --exclude PATH               Exclude path(s) from being linted.

[poliva83]

Also had to change bin files to get rubocop ruby-parse ruby-rewrite and a couple others to run from command line.

[carpnick]

Looks like the chef exec command is screwing up the path environment variable:
Path=C:/opscode/chefdk/bin:C:/Users/ncarpenter/.chefdk/gem/ruby/2.0.0/bin:C:/opscode/chefdk/embedded/bin:c:\python278;......;C:\opscode\chefdk\bin

Notice there is a ":" between each of the opscode freshly added paths:
C:/opscode/chefdk/bin:C:/Users/ncarpenter/.chefdk/gem/ruby/2.0.0/bin:C:/opscode/chefdk/embedded/bin:
This needs to be semi-colons

[carpnick]

This is a generic pathing problem - not foodcritic related.

[danielsdeleo]

Correct, this line needs to be using the ruby File::PATH_SEPARATOR constant: https://github.com/opscode/chef-dk/blob/7c4f55cd1665727203aef211bb3e5931d2ac8547/lib/chef-dk/helpers.rb#L86