Skip to content
This repository has been archived by the owner on Jun 28, 2018. It is now read-only.

Enable appbundler for foodcritic. #254

Merged
merged 1 commit into from
Oct 1, 2014
Merged

Conversation

sersut
Copy link

@sersut sersut commented Oct 1, 2014

Fixes chef-boneyard/chef-dk#165

/cc: @opscode/client-engineers

@lamont-granquist
Copy link
Contributor

can we not appbundle something that has been gem installed? other than that, LGTM

@danielsdeleo
Copy link
Contributor

@lamont-granquist appbundler only works on something that's installed with bundler. You could maybe adapt it to bundle install a Gemfile with just the one dep (i.e., foodcritic in this case) and have special logic to load the actual executable, but you'd need to hack appbundler to do more gem magic.

@danielsdeleo
Copy link
Contributor

Patch LGTM 👍

@lamont-granquist
Copy link
Contributor

okay :shipit:

sersut pushed a commit that referenced this pull request Oct 1, 2014
@sersut sersut merged commit 2fb382a into master Oct 1, 2014
@sersut sersut deleted the sersut/appbundle-foodcritic branch October 1, 2014 16:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Foodcritic not running correctly after installing 0.2.2 msi on windows 7
4 participants