-
Notifications
You must be signed in to change notification settings - Fork 170
Adds a kitchen flag that gives options for different kitchen configs #1517
Adds a kitchen flag that gives options for different kitchen configs #1517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 from me. Kinda wondering if we should try to unify the kitchen yaml templates but IMO we can merge this and clean that up later should we decide it's needed.
I imagine if we tried to merge these would place more logic in the recipe that could make sense. Most of that content could be represented as JSON and then inserted correctly. Comments would be a meta-field in that data structure that would render alongside the appropriate field. I'd be happy to make that change here or in a future commit if this approach and YET ANOTHER FLAG is the best way to proceed. |
image: dokken/ubuntu-16.04 | ||
- name: centos-7 | ||
driver: | ||
image: dokken/centos-7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Option: could add the "so you want to verify services?" shenanigans to these driver entries in the platform section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it’s a good idea. Of course based on our conversation it assumes you’re running on a *nix based system.
I’d be interested in learning the windows option if that is known and add that.
@burtlo thanks for posting those diffs. It actually made me realize we need to delete the policyfile one. Doing that would bring us back to just 2 templates which is below the "rule of 3" for refactoring so just ignore my earlier comment :) |
To provide support out-of-the-box for kitchen-dokken there is a flag now to specify which base kitchen configuration to use. Signed-off-by: Franklin Webber <franklin@chef.io>
9df4e0f
to
e7fd003
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR: #1517 Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
To provide support out-of-the-box for
kitchen-dokken
there is a flag now to specify which base kitchen configuration to use.Signed-off-by: Franklin Webber franklin@chef.io