This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Fixing bug in expeditor script to update dependencies #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For loop was using wrong syntax. Also updating dependencies since these need to go in too. Signed-off-by: tyler-ball <tball@chef.io>
marcparadise
approved these changes
Nov 14, 2018
robbkidd
reviewed
Nov 14, 2018
| @@ -21,7 +21,7 @@ git checkout -b "$branch" | |||
| gem install rake | |||
|
|
|||
| tries=6 | |||
| for i in {1..$tries}; do | |||
| for (( i=1; i<=$tries; i+=1 )); do | |||
There was a problem hiding this comment.
I guess we can go with a purely bash iterator. 🙄
robbkidd
reviewed
Nov 14, 2018
| @@ -203,7 +203,7 @@ GEM | |||
| mixlib-log (~> 2.0) | |||
| rack (~> 2.0) | |||
| uuidtools (~> 2.1) | |||
| cheffish (14.0.1) | |||
| cheffish (14.0.4) | |||
There was a problem hiding this comment.
Do we want to bring the unrelated cheffish update along in this PR? Or correct #1825 ?
There was a problem hiding this comment.
We need to update Inspec too, and this fixes the script that updates the dependencies, so I figured we could do it all here rather than waiting 2+ hours for all the extra builds
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For loop was using wrong syntax. Also updating dependencies since these
need to go in too.
Issues Resolved
☝️
Check List
New functionality includes testsSigned-off-by: tyler-ball tball@chef.io