This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Adding license acceptance support to ChefDK #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-ball
force-pushed
the
license_acceptance
branch
from
5a486f6 to
73c3cab
Compare
tas50
reviewed
May 14, 2019
Signed-off-by: tyler-ball <tball@chef.io>
tyler-ball
force-pushed
the
license_acceptance
branch
from
73c3cab to
604b731
Compare
lamont-granquist
approved these changes
May 16, 2019
tyler-ball
commented
May 16, 2019
lib/chef-dk/command/env.rb
Outdated
| @@ -34,6 +34,10 @@ def initialize(*args) | |||
| @ui = UI.new | |||
| end | |||
|
|
|||
| def check_license_acceptance | |||
| # Do not need to accept the license for checking the environment | |||
There was a problem hiding this comment.
We do not request the license for knife which made me think we shouldn't request the license here. But then I remembered that knife is not a trademarked term so that is why we don't request the EULA there, so I'm going to request the EULA for all chef subcommands besides -v and -h
Signed-off-by: tyler-ball <tball@chef.io>
tyler-ball
force-pushed
the
license_acceptance
branch
from
604b731 to
06069af
Compare
marcparadise
approved these changes
May 16, 2019
5 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds in license acceptance support to the
chefcommandIssues Resolved
Check List