Added fauxhai, rubocop, knife-spork, and kitchen-vagrant to verify #235
Conversation
|
might be useful to do something more than --version, but this is vastly better than nothing. |
|
|
||
| add_component "knife-spork" do |c| | ||
| c.gem_base_dir = "knife-spork" | ||
| c.unit_test { sh('rake test') } |
There was a problem hiding this comment.
Instead of rake test I think we can run this:
$ knife spork info
Config Hash:
{}
Plugins:
KnifeSpork::Plugins::Campfire: disabled
KnifeSpork::Plugins::Eventinator: disabled
KnifeSpork::Plugins::Foodcritic: disabled
KnifeSpork::Plugins::Git: disabled
KnifeSpork::Plugins::Graphite: disabled
KnifeSpork::Plugins::Grove: disabled
KnifeSpork::Plugins::HipChat: disabled
KnifeSpork::Plugins::Irccat: disabled
KnifeSpork::Plugins::Jabber: disabled
KnifeSpork::Plugins::Rubocop: disabled
KnifeSpork::Plugins::Slack: disabled
KnifeSpork::Plugins::StatusNet: disabled
| c.smoke_test { sh("rubocop --version") } | ||
| c.smoke_test do | ||
| tmpdir do |cwd| | ||
| with_file(File.join(cwd, 'foo.rb')) do |f| |
There was a problem hiding this comment.
At the risk of asking for trouble, won't this automatically open the file in $PWD?
There was a problem hiding this comment.
i don't think so, tmp dir will create a dir and return that as cwd, which gets joined to foo.rb
jaym
force-pushed
the
jdmundrawala/enhance-verify
branch
from
43f5298 to
f5f9191
Compare
|
@lamont-granquist @btm @sersut I've added something better than version. |
jaym
force-pushed
the
jdmundrawala/enhance-verify
branch
from
405f75a to
08e75ef
Compare
|
@jdmundrawala The rubocop smoke test looks 👍 - what about @sersut's question for spork? |
|
@tyler-ball it's there, not sure why it does not show up under the comment view. Check the file directory |
|
@jdmundrawala I see it now - thanks. If the I'm just making sure I understand how |
|
@tyler-ball the way these work is, the test block returns a Mixlib::ShellOut object (or compatible type), and |
| tmpdir do |cwd| | ||
| with_file(File.join(cwd, 'foo.rb')) do |f| | ||
| f.write <<-EOF | ||
| def foo |
There was a problem hiding this comment.
@kwilczynski I don't think so - it seems to me that he is writing out some ruby code and then running rubocop on it to validate that rubocop is installed and working correctly.
|
👍 |
Added fauxhai, rubocop, knife-spork, and kitchen-vagrant to verify
This will cause verify to fail on Windows, catching #221
Working on a change to omnibus-chef to correct this problem.
cc @btm @opscode/client-engineers