-
Notifications
You must be signed in to change notification settings - Fork 170
Added fauxhai, rubocop, knife-spork, and kitchen-vagrant to verify #235
Changes from all commits
0df5c9e
3b64cf8
ab17603
239b8e6
e32a252
6429183
08e75ef
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -143,6 +143,39 @@ def components | |
end | ||
end | ||
|
||
add_component "rubocop" do |c| | ||
c.gem_base_dir = "rubocop" | ||
c.smoke_test do | ||
tmpdir do |cwd| | ||
with_file(File.join(cwd, 'foo.rb')) do |f| | ||
f.write <<-EOF | ||
def foo | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Some debug left-overs? 🍒 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kwilczynski I don't think so - it seems to me that he is writing out some ruby code and then running There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what @tyler-ball said |
||
puts 'foo' | ||
end | ||
EOF | ||
end | ||
sh("rubocop foo.rb -l", cwd: cwd) | ||
end | ||
end | ||
end | ||
|
||
add_component "fauxhai" do |c| | ||
c.gem_base_dir = "fauxhai" | ||
c.smoke_test { sh("fauxhai") } | ||
end | ||
|
||
add_component "knife-spork" do |c| | ||
c.gem_base_dir = "knife-spork" | ||
c.unit_test { sh('rake test') } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of rake test I think we can run this:
|
||
c.smoke_test { sh('knife spork info')} | ||
end | ||
|
||
add_component "kitchen-vagrant" do |c| | ||
c.gem_base_dir = "kitchen-vagrant" | ||
# The build is not passing in travis, so no tests | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And maybe we can test this with: |
||
c.smoke_test { sh("gem list kitchen-vagrant") } | ||
end | ||
|
||
add_component "package installation" do |c| | ||
|
||
c.base_dir = "chef-dk" | ||
|
@@ -181,7 +214,6 @@ def components | |
# object: | ||
ComponentTest::NullTestResult.new | ||
end | ||
|
||
end | ||
|
||
attr_reader :verification_threads | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the risk of asking for trouble, won't this automatically open the file in $PWD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think so, tmp dir will create a dir and return that as cwd, which gets joined to foo.rb