update mockgen to 1.4.3 #3379
Merged
update mockgen to 1.4.3 #3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This release of mockgen has an important speed improvement: golang/mock#397 On linux, with tools already installed and a primed cache, we go from: > time compile_client_mocks ... real 0m55.859s user 1m39.088s sys 1m40.395s to > time compile_client_mocks ... real 0m9.133s user 0m12.420s sys 0m7.568s Unfortunately, on macOS+Docker, the impact isn't as dramatic: > time compile_client_mocks ... real 1m32.170s user 1m46.861s sys 2m31.633s to > time compile_client_mocks ... real 1m8.510s user 0m21.225s sys 0m24.807s Signed-off-by: Steven Danna <steve@chef.io>
|
The massive line increase is mostly from: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release of mockgen has an important speed improvement:
golang/mock#397
On linux, with tools already installed and a primed cache, we go from:
to
Unfortunately, on macOS+Docker, the impact isn't as dramatic:
to
Signed-off-by: Steven Danna steve@chef.io