Improve performance of mock generation (#396) #397

plakhotnii · 2020-02-17T08:53:44Z

Fixes #396. This PR optimise resolving correct package name with go list command. Instead of calling go list for each import in file, now we do it for all imports in one call.

Time consuming by mockgen:

Source mode

(v1.4.0)
time ../mockgen -source user.go -destination mock_user/mock_user.go Index,Embed,Embedded
../mockgen -source user.go -destination mock_user/mock_user.go   2.09s user 2.83s system 280% cpu 1.756 total
(with optimizations)
time ../mockgen -source user.go -destination mock_user/mock_user.go Index,Embed,Embedded
../mockgen -source user.go -destination mock_user/mock_user.go   0.54s user 0.63s system 320% cpu 0.364 total

Reflection mode

(v1.4.0)
time ../mockgen -destination mock_user/mock_user.go github.com/golang/mock/sample Index,Embed,Embedded
../mockgen -destination mock_user/mock_user.go  Index,Embed,Embedded  1.73s user 1.72s system 199% cpu 1.731 total
(with optimizations)
time ../mockgen -destination mock_user/mock_user.go github.com/golang/mock/sample Index,Embed,Embedded
../mockgen -destination mock_user/mock_user.go github.com/golang/mock/sample  0.96s user 0.53s system 153% cpu 0.972 total

googlebot · 2020-02-17T08:53:50Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-02-17T08:53:50Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

plakhotnii · 2020-02-17T09:17:15Z

@googlebot I signed it!

googlebot · 2020-02-17T09:17:19Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot · 2020-02-17T09:17:20Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

codyoss

Like the idea overall, lets just work through a couple of my nitpicks. Thanks!

mockgen/mockgen.go

mockgen/parse.go

mockgen/mockgen.go

mockgen/mockgen_test.go

mockgen/mockgen.go

codyoss

Thanks for making the updates. Just a couple more things and then we can get this merged!

mockgen/mockgen.go

codyoss · 2020-02-22T21:35:05Z

Thanks for working through this with me @plakhotnii and thank you for your contribution! 🎆

rafaeljusto · 2020-02-25T14:33:07Z

@codyoss Could you please release the v1.5.0? This fix here will help me a lot. 🙂

codyoss · 2020-02-25T16:46:02Z

@rafaeljusto I can cut a version later today or tomorrow. Will just be a path: v1.4.1.

rafaeljusto · 2020-02-25T16:54:13Z

Perfect, thanks!

codyoss · 2020-02-28T00:10:41Z

@rafaeljusto I did a release last night 😺

rafaeljusto · 2020-02-28T08:47:35Z

Thank you! 😄

This release of mockgen has an important speed improvement: golang/mock#397 Signed-off-by: Steven Danna <steve@chef.io>

This release of mockgen has an important speed improvement: golang/mock#397 On linux, with tools already installed and a primed cache, we go from: > time compile_client_mocks ... real 0m55.859s user 1m39.088s sys 1m40.395s to > time compile_client_mocks ... real 0m9.133s user 0m12.420s sys 0m7.568s Unfortunately, on macOS+Docker, the impact isn't as dramatic: > time compile_client_mocks ... real 1m32.170s user 1m46.861s sys 2m31.633s to > time compile_client_mocks ... real 1m8.510s user 0m21.225s sys 0m24.807s Signed-off-by: Steven Danna <steve@chef.io>

improve performance of mock generation (#396)

a53af46

plakhotnii requested a review from codyoss February 18, 2020 10:35

codyoss suggested changes Feb 21, 2020

View reviewed changes

fix code review mentions, process go list output as json (#396)

a774640

codyoss suggested changes Feb 22, 2020

View reviewed changes

mockgen/mockgen.go Outdated Show resolved Hide resolved

mockgen/mockgen.go Outdated Show resolved Hide resolved

mockgen/mockgen.go Outdated Show resolved Hide resolved

fix code review mentions (#396)

3981ef4

codyoss approved these changes Feb 22, 2020

View reviewed changes

codyoss added this to the v1.5.0 milestone Feb 22, 2020

codyoss merged commit b48cb66 into golang:master Feb 22, 2020

codyoss removed this from the v1.5.0 milestone Feb 27, 2020

stevendanna added a commit to chef/automate that referenced this pull request Apr 16, 2020

update mockgen to 1.4.3

ff4cdd8

This release of mockgen has an important speed improvement: golang/mock#397 Signed-off-by: Steven Danna <steve@chef.io>

stevendanna mentioned this pull request Apr 16, 2020

update mockgen to 1.4.3 chef/automate#3379

Merged

dependabot bot mentioned this pull request Mar 11, 2021

Bump github.com/golang/mock from 1.2.0 to 1.5.0 awslabs/amazon-ecs-local-container-endpoints#57

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve performance of mock generation (#396) #397

Improve performance of mock generation (#396) #397

plakhotnii commented Feb 17, 2020

googlebot commented Feb 17, 2020

googlebot commented Feb 17, 2020

plakhotnii commented Feb 17, 2020

googlebot commented Feb 17, 2020

googlebot commented Feb 17, 2020

codyoss left a comment

codyoss left a comment

codyoss commented Feb 22, 2020

rafaeljusto commented Feb 25, 2020

codyoss commented Feb 25, 2020

rafaeljusto commented Feb 25, 2020

codyoss commented Feb 28, 2020

rafaeljusto commented Feb 28, 2020

Improve performance of mock generation (#396) #397

Improve performance of mock generation (#396) #397

Conversation

plakhotnii commented Feb 17, 2020

googlebot commented Feb 17, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented Feb 17, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

plakhotnii commented Feb 17, 2020

googlebot commented Feb 17, 2020

googlebot commented Feb 17, 2020

codyoss left a comment

Choose a reason for hiding this comment

codyoss left a comment

Choose a reason for hiding this comment

codyoss commented Feb 22, 2020

rafaeljusto commented Feb 25, 2020

codyoss commented Feb 25, 2020

rafaeljusto commented Feb 25, 2020

codyoss commented Feb 28, 2020

rafaeljusto commented Feb 28, 2020